From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/5] decimal: provide MP_DECIMAL extension serializer
Date: Tue, 12 May 2020 23:56:28 +0300 [thread overview]
Message-ID: <20200512205628.GH2219@grain> (raw)
In-Reply-To: <87a91d28-3c4c-a37e-40c0-595faa0ea0d5@tarantool.org>
On Tue, May 12, 2020 at 10:30:24PM +0200, Vladislav Shpilevoy wrote:
> >
> > This looks suspicious -- if buffer size is not enough the snprintf
> > returns not the number of bytes really written but rather a number
> > of bytes needed to write the desired string. Are you sure it is
> > safe to return snprintf result here?
>
> Yes, I am sure it is safe and correct. mp_snprint() returns exactly this -
> an snprintf-like result. So all printers, used inside of it, should do the
> same. At least this is what is documented and covered by existing tests.
Yeah, I realized later than this is don on purpose, that's why I put
my ack in reply.
next prev parent reply other threads:[~2020-05-12 20:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 23:45 [Tarantool-patches] [PATCH 0/5] mp_snprint() and mp_fprint() for decimal, uuid, error Vladislav Shpilevoy
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 1/5] msgpuck: bump version to enable extension printer Vladislav Shpilevoy
2020-05-12 17:34 ` Cyrill Gorcunov
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 2/5] decimal: provide MP_DECIMAL extension serializer Vladislav Shpilevoy
2020-05-12 15:13 ` Cyrill Gorcunov
2020-05-12 20:30 ` Vladislav Shpilevoy
2020-05-12 20:56 ` Cyrill Gorcunov [this message]
2020-05-12 17:35 ` Cyrill Gorcunov
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 3/5] uuid: provide MP_UUID " Vladislav Shpilevoy
2020-05-12 17:36 ` Cyrill Gorcunov
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 4/5] error: provide MP_ERROR " Vladislav Shpilevoy
2020-05-12 17:52 ` Cyrill Gorcunov
2020-05-12 20:38 ` Vladislav Shpilevoy
2020-05-12 21:27 ` Cyrill Gorcunov
2020-05-18 15:24 ` Serge Petrenko
2020-05-13 12:31 ` Nikita Pettik
2020-05-13 22:10 ` Vladislav Shpilevoy
2020-05-14 2:32 ` Nikita Pettik
2020-05-14 21:28 ` Vladislav Shpilevoy
2020-05-19 13:21 ` Nikita Pettik
2020-05-20 21:57 ` Vladislav Shpilevoy
2020-05-19 11:51 ` Alexander Turenko
2020-05-19 20:48 ` Vladislav Shpilevoy
2020-05-11 23:45 ` [Tarantool-patches] [PATCH 5/5] msgpuck: activate MP_EXT custom serializers Vladislav Shpilevoy
2020-05-12 17:52 ` Cyrill Gorcunov
2020-05-13 21:06 ` Nikita Pettik
2020-05-13 21:48 ` Vladislav Shpilevoy
2020-05-14 2:24 ` Nikita Pettik
2020-05-14 21:27 ` Vladislav Shpilevoy
2020-05-19 12:11 ` Alexander Turenko
2020-05-19 20:48 ` Vladislav Shpilevoy
2020-05-19 13:23 ` Nikita Pettik
2020-05-18 15:25 ` [Tarantool-patches] [PATCH 0/5] mp_snprint() and mp_fprint() for decimal, uuid, error Serge Petrenko
2020-05-21 18:25 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512205628.GH2219@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/5] decimal: provide MP_DECIMAL extension serializer' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox