From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: HustonMmmavr <huston.mavr@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form
Date: Fri, 8 May 2020 15:39:27 +0300 [thread overview]
Message-ID: <20200508123927.GB2626@hpalx> (raw)
In-Reply-To: <20200508101703.8928-1-huston.mavr@gmail.com>
Hi Aleksandr, thanks for the patch, LGTM.
On Fri, May 08, 2020 at 01:17:03PM +0300, HustonMmmavr wrote:
> According to dockerfile reference, there are two forms of specifying
> entrypoint: exec and shell. Exec form is preferred and allows to use
> this image in scripts.
>
> Close #4960
> ---
> Issue: https://github.com/tarantool/tarantool/issues/4960
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-4960-inappropriate-dockerfile.staticbuild-syntax
> Dockerfile.staticbuild | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index a1c47a85e..253f2d5e9 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -95,4 +95,4 @@ RUN if [ -n "${RUN_TESTS}" ]; then \
> /usr/bin/python test-run.py --force; \
> fi
>
> -ENTRYPOINT /bin/bash
> +ENTRYPOINT ["/bin/bash"]
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-05-08 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 10:17 HustonMmmavr
2020-05-08 12:39 ` Alexander V. Tikhonov [this message]
2020-05-08 13:30 ` Sergey Bronnikov
2020-05-08 13:36 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508123927.GB2626@hpalx \
--to=avtikhon@tarantool.org \
--cc=huston.mavr@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=yaroslav.dynnikov@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox