From: Serge Petrenko <sergepetrenko@tarantool.org> To: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH] refactoring: sync declarations w/ definitions Date: Fri, 8 May 2020 14:21:05 +0300 [thread overview] Message-ID: <20200508112105.31303-1-sergepetrenko@tarantool.org> (raw) Commit b136a61e51ac871f32658b611d4ce7b7f7d5363c already fixed a similar problem with build failure on OS X, but later box_return_mp() and box_session_push() were exported, so their declarations and definitions also need to be synced. Add API_EXPORT attribute to the definitions of these functions. Follow-up #4885 --- https://github.com/tarantool/tarantool/issues/4885 https://github.com/tarantool/tarantool/tree/sp/fix-compiler-warn src/box/box.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/box/box.cc b/src/box/box.cc index ae0907e0f..909af0999 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -1075,7 +1075,7 @@ box_return_tuple(box_function_ctx_t *ctx, box_tuple_t *tuple) return port_c_add_tuple(ctx->port, tuple); } -int +API_EXPORT int box_return_mp(box_function_ctx_t *ctx, const char *mp, const char *mp_end) { return port_c_add_mp(ctx->port, mp, mp_end); @@ -1461,7 +1461,7 @@ box_sequence_reset(uint32_t seq_id) return sequence_data_delete(seq_id); } -int +API_EXPORT int box_session_push(const char *data, const char *data_end) { struct session *session = current_session(); -- 2.24.2 (Apple Git-127)
next reply other threads:[~2020-05-08 11:21 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-08 11:21 Serge Petrenko [this message] 2020-05-08 11:45 ` Serge Petrenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200508112105.31303-1-sergepetrenko@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] refactoring: sync declarations w/ definitions' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox