* [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form
@ 2020-05-08 10:17 HustonMmmavr
2020-05-08 12:39 ` Alexander V. Tikhonov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: HustonMmmavr @ 2020-05-08 10:17 UTC (permalink / raw)
To: tarantool-patches, yaroslav.dynnikov
According to dockerfile reference, there are two forms of specifying
entrypoint: exec and shell. Exec form is preferred and allows to use
this image in scripts.
Close #4960
---
Issue: https://github.com/tarantool/tarantool/issues/4960
Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-4960-inappropriate-dockerfile.staticbuild-syntax
Dockerfile.staticbuild | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
index a1c47a85e..253f2d5e9 100644
--- a/Dockerfile.staticbuild
+++ b/Dockerfile.staticbuild
@@ -95,4 +95,4 @@ RUN if [ -n "${RUN_TESTS}" ]; then \
/usr/bin/python test-run.py --force; \
fi
-ENTRYPOINT /bin/bash
+ENTRYPOINT ["/bin/bash"]
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form
2020-05-08 10:17 [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form HustonMmmavr
@ 2020-05-08 12:39 ` Alexander V. Tikhonov
2020-05-08 13:30 ` Sergey Bronnikov
2020-05-08 13:36 ` Kirill Yukhin
2 siblings, 0 replies; 4+ messages in thread
From: Alexander V. Tikhonov @ 2020-05-08 12:39 UTC (permalink / raw)
To: HustonMmmavr; +Cc: tarantool-patches, yaroslav.dynnikov
Hi Aleksandr, thanks for the patch, LGTM.
On Fri, May 08, 2020 at 01:17:03PM +0300, HustonMmmavr wrote:
> According to dockerfile reference, there are two forms of specifying
> entrypoint: exec and shell. Exec form is preferred and allows to use
> this image in scripts.
>
> Close #4960
> ---
> Issue: https://github.com/tarantool/tarantool/issues/4960
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-4960-inappropriate-dockerfile.staticbuild-syntax
> Dockerfile.staticbuild | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index a1c47a85e..253f2d5e9 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -95,4 +95,4 @@ RUN if [ -n "${RUN_TESTS}" ]; then \
> /usr/bin/python test-run.py --force; \
> fi
>
> -ENTRYPOINT /bin/bash
> +ENTRYPOINT ["/bin/bash"]
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form
2020-05-08 10:17 [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form HustonMmmavr
2020-05-08 12:39 ` Alexander V. Tikhonov
@ 2020-05-08 13:30 ` Sergey Bronnikov
2020-05-08 13:36 ` Kirill Yukhin
2 siblings, 0 replies; 4+ messages in thread
From: Sergey Bronnikov @ 2020-05-08 13:30 UTC (permalink / raw)
To: HustonMmmavr; +Cc: tarantool-patches, yaroslav.dynnikov
On 13:17 Fri 08 May , HustonMmmavr wrote:
> According to dockerfile reference, there are two forms of specifying
> entrypoint: exec and shell. Exec form is preferred and allows to use
> this image in scripts.
>
> Close #4960
thanks for the patch, LGTM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form
2020-05-08 10:17 [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form HustonMmmavr
2020-05-08 12:39 ` Alexander V. Tikhonov
2020-05-08 13:30 ` Sergey Bronnikov
@ 2020-05-08 13:36 ` Kirill Yukhin
2 siblings, 0 replies; 4+ messages in thread
From: Kirill Yukhin @ 2020-05-08 13:36 UTC (permalink / raw)
To: HustonMmmavr; +Cc: tarantool-patches, yaroslav.dynnikov
Hello,
On 08 май 13:17, HustonMmmavr wrote:
> According to dockerfile reference, there are two forms of specifying
> entrypoint: exec and shell. Exec form is preferred and allows to use
> this image in scripts.
>
> Close #4960
I've checked your patch into 1.10, 2.3, 2.4 and master.
--
Regrads, Kirill Yukhin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-08 13:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 10:17 [Tarantool-patches] [PATCH] static build: set dockerfile entrypoint to exec form HustonMmmavr
2020-05-08 12:39 ` Alexander V. Tikhonov
2020-05-08 13:30 ` Sergey Bronnikov
2020-05-08 13:36 ` Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox