Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] console: check on_shutdown() before exit
Date: Fri, 8 May 2020 10:20:38 +0300	[thread overview]
Message-ID: <20200508072038.psdtxsy2yanuivt3@tarantool.org> (raw)
In-Reply-To: <20200411231034.95903-1-roman.habibov@tarantool.org>

Hello,

On 12 апр 02:10, Roman Khabibov wrote:
> Add check that on_shutdown() triggers were called before exit,
> because in case of EOF or Ctrl+D (no signals) they were ignored.
> 
> Closes #4703

LGTM.

I've checked your patch into 2.3, 2.4 and master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2020-05-08  7:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-11 23:10 Roman Khabibov
2020-04-12 10:37 ` Cyrill Gorcunov
2020-04-15  1:57   ` Roman Khabibov
2020-04-16 14:03     ` Cyrill Gorcunov
2020-04-17  6:55 ` Kirill Yukhin
2020-04-17 11:36   ` Roman Khabibov
2020-05-08  7:20 ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200508072038.psdtxsy2yanuivt3@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=roman.habibov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] console: check on_shutdown() before exit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox