From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/2] vinyl: drop wasted runs in case range recovery fails
Date: Thu, 7 May 2020 17:16:53 +0300 [thread overview]
Message-ID: <20200507141653.GA7782@atlas> (raw)
In-Reply-To: <20200507130256.GB11724@tarantool.org>
* Nikita Pettik <korablev@tarantool.org> [20/05/07 16:05]:
> >
> > Reference counter looks like not a good information channel.
> > Could you use run->fd to check whether the run was really recovered?
> > vy_run_recover() leaves it -1, when fails.
> >
> > Otherwise this won't work the second when we will ref the run anywhere
> > else.
>
> Firstly, lsm at this point is not restored, ergo it is not functional
> and run can't be refed somewehere else - it's life span is clearly
> defined. Secondly, the problem is not in the last run (which failed to
> recover) but in those which are already recovered at the moment.
> Recovered runs feature valid fds. Finally, slice recover may fail
> not only in vy_run_recover(), but also due to oom, broken vylog etc.
> All these scenarios lead to the same situation.
It should be partially restored in case of force_recovery. It's
another bug force_recovery is not respected, I've been sending a
fix to the list a few months ago.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-05-07 14:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 19:27 [Tarantool-patches] [PATCH 0/2] Fix crash in case of lack of FDs during recovery Nikita Pettik
2020-04-30 19:27 ` [Tarantool-patches] [PATCH 1/2] errinj: introduce delayed injection Nikita Pettik
2020-04-30 20:15 ` Konstantin Osipov
2020-04-30 20:55 ` Nikita Pettik
2020-05-01 19:15 ` Konstantin Osipov
2020-05-03 19:20 ` Vladislav Shpilevoy
2020-05-07 13:50 ` Nikita Pettik
2020-05-07 21:47 ` Vladislav Shpilevoy
2020-05-07 22:41 ` Nikita Pettik
2020-04-30 19:27 ` [Tarantool-patches] [PATCH 2/2] vinyl: drop wasted runs in case range recovery fails Nikita Pettik
2020-05-03 19:21 ` Vladislav Shpilevoy
2020-05-07 13:02 ` Nikita Pettik
2020-05-07 14:16 ` Konstantin Osipov [this message]
2020-05-07 21:47 ` Vladislav Shpilevoy
2020-05-07 22:37 ` Nikita Pettik
2020-05-07 21:47 ` Vladislav Shpilevoy
2020-05-07 22:36 ` Nikita Pettik
2020-05-10 19:59 ` Vladislav Shpilevoy
2020-05-12 1:16 ` Nikita Pettik
2020-05-03 19:20 ` [Tarantool-patches] [PATCH 0/2] Fix crash in case of lack of FDs during recovery Vladislav Shpilevoy
2020-05-07 14:11 ` Nikita Pettik
2020-05-12 20:53 ` Vladislav Shpilevoy
2020-05-12 20:56 ` Vladislav Shpilevoy
2020-05-12 22:45 ` Nikita Pettik
2020-05-13 20:19 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507141653.GA7782@atlas \
--to=kostja.osipov@gmail.com \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] vinyl: drop wasted runs in case range recovery fails' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox