From: Nikita Pettik <korablev@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 0/2] Fix crash in case of lack of FDs during recovery Date: Thu, 7 May 2020 14:11:13 +0000 [thread overview] Message-ID: <20200507141113.GD11724@tarantool.org> (raw) In-Reply-To: <f25233d3-8bb8-7f41-4ed7-b52740329bbb@tarantool.org> On 03 May 21:20, Vladislav Shpilevoy wrote: > Why do you base your patches on top of 1.10? Doesn't the > bug exist on master? Yep, master is affected as well. Originally I found it on 1.10 so firstly prepared patch for 1.10. There's no big difference in lsm recovery code, so patch can be backported with ease (from master to 1.10). Will push to master firstly, when patch-set is ready-to-push. Anyway, thanks for noting that. > On 30/04/2020 21:27, Nikita Pettik wrote: > > Branch: https://github.com/tarantool/tarantool/commits/np/gh-4805-too-many-fds > > Issue: https://github.com/tarantool/tarantool/issues/4805 > > > > First patch adds simple macro which allows error injection to be delayed. > > It also can be used in this series: > > https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/016367.html > > > > Nikita Pettik (2): > > errinj: introduce delayed injection > > vinyl: drop wasted runs in case range recovery fails > > > > src/box/vy_lsm.c | 14 ++- > > src/box/vy_run.c | 4 + > > src/errinj.h | 10 ++ > > test/box/errinj.result | 1 + > > test/vinyl/errinj_recovery.lua | 10 ++ > > .../gh-4805-open-run-err-recovery.result | 101 ++++++++++++++++++ > > .../gh-4805-open-run-err-recovery.test.lua | 38 +++++++ > > test/vinyl/suite.ini | 2 +- > > 8 files changed, 176 insertions(+), 4 deletions(-) > > create mode 100644 test/vinyl/errinj_recovery.lua > > create mode 100644 test/vinyl/gh-4805-open-run-err-recovery.result > > create mode 100644 test/vinyl/gh-4805-open-run-err-recovery.test.lua > >
next prev parent reply other threads:[~2020-05-07 14:11 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-30 19:27 Nikita Pettik 2020-04-30 19:27 ` [Tarantool-patches] [PATCH 1/2] errinj: introduce delayed injection Nikita Pettik 2020-04-30 20:15 ` Konstantin Osipov 2020-04-30 20:55 ` Nikita Pettik 2020-05-01 19:15 ` Konstantin Osipov 2020-05-03 19:20 ` Vladislav Shpilevoy 2020-05-07 13:50 ` Nikita Pettik 2020-05-07 21:47 ` Vladislav Shpilevoy 2020-05-07 22:41 ` Nikita Pettik 2020-04-30 19:27 ` [Tarantool-patches] [PATCH 2/2] vinyl: drop wasted runs in case range recovery fails Nikita Pettik 2020-05-03 19:21 ` Vladislav Shpilevoy 2020-05-07 13:02 ` Nikita Pettik 2020-05-07 14:16 ` Konstantin Osipov 2020-05-07 21:47 ` Vladislav Shpilevoy 2020-05-07 22:37 ` Nikita Pettik 2020-05-07 21:47 ` Vladislav Shpilevoy 2020-05-07 22:36 ` Nikita Pettik 2020-05-10 19:59 ` Vladislav Shpilevoy 2020-05-12 1:16 ` Nikita Pettik 2020-05-03 19:20 ` [Tarantool-patches] [PATCH 0/2] Fix crash in case of lack of FDs during recovery Vladislav Shpilevoy 2020-05-07 14:11 ` Nikita Pettik [this message] 2020-05-12 20:53 ` Vladislav Shpilevoy 2020-05-12 20:56 ` Vladislav Shpilevoy 2020-05-12 22:45 ` Nikita Pettik 2020-05-13 20:19 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200507141113.GD11724@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/2] Fix crash in case of lack of FDs during recovery' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox