From: Sergey Ostanevich <sergos@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] wal: simplify rollback
Date: Thu, 7 May 2020 13:28:05 +0300 [thread overview]
Message-ID: <20200507102805.GI112@tarantool.org> (raw)
In-Reply-To: <9a29772d-0ade-5735-adc1-536d4e76a1f1@tarantool.org>
Hi!
Thank you for the very detailed explanation of rollback activities
between WAL and TX threads! Now it's pretty clear how you made it work.
Neato!
> >>
> >> Also there is now a single route for commit and rollback cbus
> > ^^^ move it
> >> messages, called tx_complete_batch(). This change will come in
> > ^^^ here
>
> Nope. Beforehand there was no a single route, and *now* there is a
> single route. Which happened to be called tx_complete_batch(). The
> accent is on *now there is a single route*. Not on *now it is called*.
What I mean is actually "Also there is a single route for commit and
rollback cbus messages now, called tx_complete_batch().
Sorry for misleading.
LGTM.
Sergos
next prev parent reply other threads:[~2020-05-07 10:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 22:50 Vladislav Shpilevoy
2020-05-03 10:46 ` Konstantin Osipov
2020-05-03 16:45 ` Vladislav Shpilevoy
2020-05-03 19:30 ` Konstantin Osipov
2020-05-06 7:55 ` Cyrill Gorcunov
2020-05-06 15:38 ` Sergey Ostanevich
2020-05-06 21:43 ` Vladislav Shpilevoy
2020-05-07 10:28 ` Sergey Ostanevich [this message]
2020-05-07 21:37 ` Vladislav Shpilevoy
2020-05-08 8:12 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507102805.GI112@tarantool.org \
--to=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] wal: simplify rollback' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox