From: Nikita Pettik <korablev@tarantool.org> To: Aleksandr Lyapunov <alyapunov@tarantool.org> Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Subject: Re: [Tarantool-patches] [PATCH v3 1/3] vinyl: init all vars before cleanup in vy_lsm_split_range() Date: Thu, 7 May 2020 01:09:08 +0000 [thread overview] Message-ID: <20200507010907.GD9992@tarantool.org> (raw) In-Reply-To: <6d861b87-9a24-77c8-a306-0299f4b88985@tarantool.org> On 06 May 20:52, Aleksandr Lyapunov wrote: > I agree. This particular commit lgtm. Pushed to master; cherry-picked on 2.4, 2.3 and 1.10. > On 5/6/20 4:12 PM, Nikita Pettik wrote: > > On 06 May 12:04, Aleksandr Lyapunov wrote: > > > Nice catch! Jumps over initialization must be prohibited. As C++ prohibits. > > > > > If everyone is okay with this patch, let's push it out of order.
next prev parent reply other threads:[~2020-05-07 1:09 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-27 0:52 [Tarantool-patches] [PATCH v3 0/3] vinyl: fix uninitialized memory accesses Nikita Pettik 2020-04-27 0:52 ` [Tarantool-patches] [PATCH v3 1/3] vinyl: init all vars before cleanup in vy_lsm_split_range() Nikita Pettik 2020-05-06 9:04 ` Aleksandr Lyapunov 2020-05-06 13:12 ` Nikita Pettik 2020-05-06 17:52 ` Aleksandr Lyapunov 2020-05-07 1:09 ` Nikita Pettik [this message] 2020-04-27 0:52 ` [Tarantool-patches] [PATCH v3 2/3] vinyl: clean-up unprocessed read views in *_build_read_views() Nikita Pettik 2020-05-06 9:56 ` Aleksandr Lyapunov 2020-05-07 0:29 ` Nikita Pettik 2020-05-07 8:44 ` Aleksandr Lyapunov 2020-05-07 12:28 ` Nikita Pettik 2020-04-27 0:52 ` [Tarantool-patches] [PATCH v3 3/3] vinyl: clean-up write iterator if vy_task_write_run() fails Nikita Pettik 2020-05-01 0:55 ` Vladislav Shpilevoy 2020-05-03 9:22 ` Konstantin Osipov 2020-05-07 0:38 ` Nikita Pettik 2020-05-06 10:37 ` Aleksandr Lyapunov 2020-05-07 0:36 ` Nikita Pettik 2020-05-07 7:53 ` Aleksandr Lyapunov 2020-05-07 22:16 ` Nikita Pettik 2020-05-08 16:29 ` Aleksandr Lyapunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200507010907.GD9992@tarantool.org \ --to=korablev@tarantool.org \ --cc=alyapunov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 1/3] vinyl: init all vars before cleanup in vy_lsm_split_range()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox