From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] test: make app-tap/init_script produce less diff
Date: Tue, 5 May 2020 19:32:54 +0300 [thread overview]
Message-ID: <20200505163254.GA51428@grain> (raw)
In-Reply-To: <d1baa7ecf136ffd60090aecdf9a081f2f9c6e607.1588358637.git.v.shpilevoy@tarantool.org>
On Fri, May 01, 2020 at 08:45:25PM +0200, Vladislav Shpilevoy wrote:
> When a new option is added, app-tap/init_script
> outputs big diff. Because all options are printed with
> ordinal indexes. Addition of a new option changes
> indexes of all options after the new one.
>
> The patch removes indexes from the output making diff
> smaller, when a new option is added.
> ---
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/app-tap/init_script-test-diff
Looks ok to me. But I CC SashaT just to make sure.
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
next prev parent reply other threads:[~2020-05-05 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 18:45 Vladislav Shpilevoy
2020-05-05 16:32 ` Cyrill Gorcunov [this message]
2020-05-15 15:11 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505163254.GA51428@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] test: make app-tap/init_script produce less diff' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox