From: Mergen Imeev <imeevma@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1 1/2] sql: fix comparison in IN with list of values Date: Thu, 30 Apr 2020 13:32:52 +0300 [thread overview] Message-ID: <20200430103251.GA4074@tarantool.org> (raw) In-Reply-To: <087ee40d-4a74-c44a-a47e-db480cb46a96@tarantool.org> Sorry, I forgot about this comment. I changed the comment in test. Diff below. On Tue, Apr 28, 2020 at 12:53:34AM +0200, Vladislav Shpilevoy wrote: > > diff --git a/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua b/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua > > new file mode 100755 > > index 0000000..14ba7ad > > --- /dev/null > > +++ b/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua > > @@ -0,0 +1,32 @@ > > +#!/usr/bin/env tarantool > > +test = require("sqltester") > > +test:plan(2) > > + > > +-- > > +-- If left value of IN and NOT IN operators is not a vector with > > +-- length more that one, make sure that it cannot be compared to > > that -> than. Diff diff --git a/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua b/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua index a03b688..5e69805 100755 --- a/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua +++ b/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua @@ -3,9 +3,8 @@ test = require("sqltester") test:plan(11) -- --- If left value of IN and NOT IN operators is not a vector with --- length more that one, make sure that it cannot be compared to --- right values in case they are not comparable. +-- Make sure that the left value of IN and NOT IN operators cannot +-- be compared to the right value in case they are not comparable. -- test:do_catchsql_test(
next prev parent reply other threads:[~2020-04-30 10:32 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-15 11:47 [Tarantool-patches] [PATCH v1 0/2] sql: fix comparison in IN operator imeevma 2020-04-15 11:47 ` [Tarantool-patches] [PATCH v1 1/2] sql: fix comparison in IN with list of values imeevma 2020-04-27 22:53 ` Vladislav Shpilevoy 2020-04-30 10:32 ` Mergen Imeev [this message] 2020-05-03 17:17 ` Vladislav Shpilevoy 2020-04-15 11:47 ` [Tarantool-patches] [PATCH v1 2/2] sql: fix comparison in IN with subselect imeevma 2020-04-19 17:47 ` Vladislav Shpilevoy 2020-04-22 10:03 ` Mergen Imeev 2020-04-27 22:53 ` Vladislav Shpilevoy 2020-04-30 10:22 ` Mergen Imeev 2020-05-03 17:17 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200430103251.GA4074@tarantool.org \ --to=imeevma@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 1/2] sql: fix comparison in IN with list of values' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox