* Re: [Tarantool-patches] [PATCH v1] Add Ubuntu Focal 20.04 packages
2020-04-28 14:43 [Tarantool-patches] [PATCH v1] Add Ubuntu Focal 20.04 packages Alexander V. Tikhonov
@ 2020-04-29 8:15 ` Sergey Bronnikov
2020-04-29 11:33 ` Oleg Piskunov
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Sergey Bronnikov @ 2020-04-29 8:15 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: Oleg Piskunov, tarantool-patches
Hi,
thanks for the patch!
LGTM
On 17:43 Tue 28 Apr , Alexander V. Tikhonov wrote:
> Added gitlab-ci and travis-ci packages creation
> for Ubuntu Focal 20.04.
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/add-ubuntu-focal-deploy-full-ci
>
> .gitlab-ci.yml | 12 ++++++++++++
> .travis.yml | 3 +++
> 2 files changed, 15 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index fd265aa60..b3b07dac5 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -334,6 +334,12 @@ ubuntu_19_10:
> OS: 'ubuntu'
> DIST: 'eoan'
>
> +ubuntu_20_04:
> + <<: *pack_definition
> + variables:
> + OS: 'ubuntu'
> + DIST: 'focal'
> +
> debian_8:
> <<: *pack_definition
> variables:
> @@ -425,6 +431,12 @@ ubuntu_19_10_deploy:
> OS: 'ubuntu'
> DIST: 'eoan'
>
> +ubuntu_20_04_deploy:
> + <<: *deploy_definition
> + variables:
> + OS: 'ubuntu'
> + DIST: 'focal'
> +
> debian_8_deploy:
> <<: *deploy_definition
> variables:
> diff --git a/.travis.yml b/.travis.yml
> index 3b9415def..dfe12fc09 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -67,6 +67,9 @@ jobs:
> - name: "Ubuntu Eoan (19.10) build + deploy DEB"
> env: OS=ubuntu DIST=eoan
> if: branch = "master"
> + - name: "Ubuntu Focal (20.04) build + deploy DEB"
> + env: OS=ubuntu DIST=focal
> + if: branch = "master"
> - name: "Debian Jessie (8) build + deploy DEB"
> env: OS=debian DIST=jessie
> if: branch = "master"
> --
> 2.17.1
>
--
sergeyb@
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] Add Ubuntu Focal 20.04 packages
2020-04-28 14:43 [Tarantool-patches] [PATCH v1] Add Ubuntu Focal 20.04 packages Alexander V. Tikhonov
2020-04-29 8:15 ` Sergey Bronnikov
@ 2020-04-29 11:33 ` Oleg Piskunov
2020-04-29 13:10 ` Alexander Turenko
2020-04-30 20:08 ` Alexander Turenko
3 siblings, 0 replies; 5+ messages in thread
From: Oleg Piskunov @ 2020-04-29 11:33 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: tarantool-patches
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
LGTM
>Вторник, 28 апреля 2020, 17:57 +03:00 от Alexander V. Tikhonov <avtikhon@tarantool.org>:
>
>Added gitlab-ci and travis-ci packages creation
>for Ubuntu Focal 20.04.
>---
>
>Github: https://github.com/tarantool/tarantool/tree/avtikhon/add-ubuntu-focal-deploy-full-ci
>
> .gitlab-ci.yml | 12 ++++++++++++
> .travis.yml | 3 +++
> 2 files changed, 15 insertions(+)
>
>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>index fd265aa60..b3b07dac5 100644
>--- a/.gitlab-ci.yml
>+++ b/.gitlab-ci.yml
>@@ -334,6 +334,12 @@ ubuntu_19_10:
> OS: 'ubuntu'
> DIST: 'eoan'
>
>+ubuntu_20_04:
>+ <<: *pack_definition
>+ variables:
>+ OS: 'ubuntu'
>+ DIST: 'focal'
>+
> debian_8:
> <<: *pack_definition
> variables:
>@@ -425,6 +431,12 @@ ubuntu_19_10_deploy:
> OS: 'ubuntu'
> DIST: 'eoan'
>
>+ubuntu_20_04_deploy:
>+ <<: *deploy_definition
>+ variables:
>+ OS: 'ubuntu'
>+ DIST: 'focal'
>+
> debian_8_deploy:
> <<: *deploy_definition
> variables:
>diff --git a/.travis.yml b/.travis.yml
>index 3b9415def..dfe12fc09 100644
>--- a/.travis.yml
>+++ b/.travis.yml
>@@ -67,6 +67,9 @@ jobs:
> - name: "Ubuntu Eoan (19.10) build + deploy DEB"
> env: OS=ubuntu DIST=eoan
> if: branch = "master"
>+ - name: "Ubuntu Focal (20.04) build + deploy DEB"
>+ env: OS=ubuntu DIST=focal
>+ if: branch = "master"
> - name: "Debian Jessie (8) build + deploy DEB"
> env: OS=debian DIST=jessie
> if: branch = "master"
>--
>2.17.1
>
--
Oleg Piskunov
[-- Attachment #2: Type: text/html, Size: 2645 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] Add Ubuntu Focal 20.04 packages
2020-04-28 14:43 [Tarantool-patches] [PATCH v1] Add Ubuntu Focal 20.04 packages Alexander V. Tikhonov
2020-04-29 8:15 ` Sergey Bronnikov
2020-04-29 11:33 ` Oleg Piskunov
@ 2020-04-29 13:10 ` Alexander Turenko
2020-04-30 20:08 ` Alexander Turenko
3 siblings, 0 replies; 5+ messages in thread
From: Alexander Turenko @ 2020-04-29 13:10 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: Oleg Piskunov, tarantool-patches
> diff --git a/.travis.yml b/.travis.yml
> index 3b9415def..dfe12fc09 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -67,6 +67,9 @@ jobs:
> - name: "Ubuntu Eoan (19.10) build + deploy DEB"
> env: OS=ubuntu DIST=eoan
> if: branch = "master"
> + - name: "Ubuntu Focal (20.04) build + deploy DEB"
> + env: OS=ubuntu DIST=focal
> + if: branch = "master"
> - name: "Debian Jessie (8) build + deploy DEB"
> env: OS=debian DIST=jessie
> if: branch = "master"
Please, rebase after
https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/016410.html
I suggest to use prefix 'gitlab-ci', since the change will be gitlab ci
only after the rebase.
WBR, Alexander Turenko.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] Add Ubuntu Focal 20.04 packages
2020-04-28 14:43 [Tarantool-patches] [PATCH v1] Add Ubuntu Focal 20.04 packages Alexander V. Tikhonov
` (2 preceding siblings ...)
2020-04-29 13:10 ` Alexander Turenko
@ 2020-04-30 20:08 ` Alexander Turenko
3 siblings, 0 replies; 5+ messages in thread
From: Alexander Turenko @ 2020-04-30 20:08 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: Oleg Piskunov, tarantool-patches
On Tue, Apr 28, 2020 at 05:57:56PM +0300, Alexander V. Tikhonov wrote:
> Added gitlab-ci and travis-ci packages creation
> for Ubuntu Focal 20.04.
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/add-ubuntu-focal-deploy-full-ci
Pushed to master, 2.4, 2.3, 1.10.
Removed Travis-CI part from master, but kept it for 2.4, 2.3 and 1.10.
Closed https://github.com/tarantool/tarantool/issues/4863 from the
commit.
Submitted PRs:
https://github.com/tarantool/tarantool-c/pull/140
https://github.com/tarantool/msgpuck/pull/12
I'll merge them if no problems will appear.
WBR, Alexander Turenko.
^ permalink raw reply [flat|nested] 5+ messages in thread