Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin <imun@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] cmake: set CMP0037 policy to NEW by default
Date: Mon, 27 Apr 2020 20:09:36 +0300	[thread overview]
Message-ID: <20200427170936.GO11314@tarantool.org> (raw)
In-Reply-To: <20200316121548.48251-1-arkholga@tarantool.org>

Olya,

Thanks for the patch! Unfortunately, the changes don't fix the
problem[1]. Did you find the approach provided by Sasha[2] wrong?

On 16.03.20, Olga Arkhangelskaia wrote:
> Remove setting old CMP0037 policy explicitly, it may be
> removed in later versions of cmake.
> 
> Closes #3587
> ---
> Branches: https://github.com/tarantool/tarantool/tree/OKriw/gh-3587-CMP0037-OLD-cmake-deprecation-warning-full-ci
> 
>  test/CMakeLists.txt | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
> index 9b5df7dc5..61bf7d5e1 100644
> --- a/test/CMakeLists.txt
> +++ b/test/CMakeLists.txt
> @@ -17,10 +17,6 @@ endfunction()
>  add_compile_flags("C;CXX"
>      "-Wno-unused-parameter")
>  
> -if(POLICY CMP0037)
> -    cmake_policy(SET CMP0037 OLD)
> -endif(POLICY CMP0037)
> -
>  add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/luajit-tap
>      COMMAND ${CMAKE_COMMAND} -E create_symlink
>          ${PROJECT_SOURCE_DIR}/third_party/luajit/test
> -- 
> 2.20.1 (Apple Git-117)
> 

[1]: https://gitlab.com/tarantool/tarantool/-/jobs/472976392#L464
[2]: https://github.com/tarantool/tarantool/issues/3587#issue-346204529

-- 
Best regards,
IM

  reply	other threads:[~2020-04-27 17:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16 12:15 Olga Arkhangelskaia
2020-04-27 17:09 ` Igor Munkin [this message]
2020-05-21 15:33   ` Olga Arkhangelskaia
2020-05-25 12:28     ` Igor Munkin
2020-05-25 16:19       ` Olga Arkhangelskaia
2020-05-26  8:59         ` Igor Munkin
2020-05-26  9:12           ` Igor Munkin
2020-05-27 10:17             ` Olga Arkhangelskaia
2020-05-27 10:15           ` Olga Arkhangelskaia
2020-06-14 22:22             ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427170936.GO11314@tarantool.org \
    --to=imun@tarantool.org \
    --cc=arkholga@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] cmake: set CMP0037 policy to NEW by default' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox