From: Nikita Pettik <korablev@tarantool.org> To: Konstantin Osipov <kostja.osipov@gmail.com>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] vinyl: unthrottle scheduler on checkpoint Date: Mon, 27 Apr 2020 15:18:54 +0000 [thread overview] Message-ID: <20200427151854.GE30870@tarantool.org> (raw) In-Reply-To: <20200427123936.GA24638@atlas> On 27 Apr 15:39, Konstantin Osipov wrote: > * Nikita Pettik <korablev@tarantool.org> [20/04/27 15:19]: > > Checkpoint daemon uses directly box.snapshot(), so now we can't tell > > whether checkpoint is launched manually or automatically. To differ > > these scenarious we can make checkpoint daemon call sort of > > box.__scheduled_snapshot() (which won't be part of public API ofc). > > Then we will be able to pass boolean parameter to begin_checkpoint() > > indicating manual/auto mode. Or simply close issue as wont fix :) > > Uhm, no, checkpoint daemon uses gc_do_checkpoint() and it doesn't > use box.snapshot(). Seems we are looking at different branches: 1.10 still uses checkpoint daemon written in Lua. If this patch should be pushed to master branch only, then I guess it would be easy to patch engine_begin_checkpoint() and make it accept argument responsible for checkpoint mode (scheduled or manual). > > -- > Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-04-27 15:18 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-31 14:42 Nikita Pettik 2020-03-31 14:53 ` Konstantin Osipov 2020-04-21 23:13 ` Vladislav Shpilevoy 2020-04-22 0:32 ` Konstantin Osipov 2020-04-27 12:17 ` Nikita Pettik 2020-04-27 12:39 ` Konstantin Osipov 2020-04-27 15:18 ` Nikita Pettik [this message] 2020-04-27 15:20 ` Konstantin Osipov 2020-04-27 15:37 ` Nikita Pettik 2020-04-27 15:48 ` Konstantin Osipov 2020-04-27 15:52 ` Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200427151854.GE30870@tarantool.org \ --to=korablev@tarantool.org \ --cc=kostja.osipov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] vinyl: unthrottle scheduler on checkpoint' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox