Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] applier: follow vclock to the last tx row
Date: Mon, 27 Apr 2020 13:22:06 +0300	[thread overview]
Message-ID: <20200427102206.4gbk5pimw3gfg2nj@tarantool.org> (raw)
In-Reply-To: <20200422182810.79257-1-sergepetrenko@tarantool.org>

Hello,

On 22 апр 21:28, Serge Petrenko wrote:
> Since the introduction of transaction boundaries in replication
> protocol, appliers follow replicaset.applier.vclock to the lsn of the
> first row in an arrived batch. This is enough and doesn't lead to errors
> when replicating from other instances, respecting transaction boundaries
> (instances with version 2.1.2 and up). However, if there's a 1.10
> instance in 2.1.2+ cluster, it sends every single tx row as a separate
> transaction, breaking the comparison with replicaset.applier.vclock and
> making the applier apply part of the changes, it has already applied
> when processing a full transaction coming from another 2.x instance.
> Such behaviour leads to ER_TUPLE_FOUND errors in the scenario described
> above.
> In order to guard from such cases, follow replicaset.applier.vclock to
> the lsn of the last row in tx.
> 
> Closes #4924
> ---
> https://github.com/tarantool/tarantool/issues/4924
> https://github.com/tarantool/tarantool/tree/sp/gh-4924-applier-duplicate-key

I've checked your patch into 2.3 and master.

--
Regards, Kirill Yukhin

  parent reply	other threads:[~2020-04-27 10:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22 18:28 Serge Petrenko
2020-04-23  9:41 ` Cyrill Gorcunov
2020-04-23  9:53   ` Serge Petrenko
2020-04-23  9:54     ` Cyrill Gorcunov
2020-04-23 11:19       ` Serge Petrenko
2020-04-26 18:55 ` Vladislav Shpilevoy
2020-04-27 10:22 ` Kirill Yukhin [this message]
2020-04-27 10:39   ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427102206.4gbk5pimw3gfg2nj@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] applier: follow vclock to the last tx row' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox