From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Add a check whether glibc is used
Date: Sat, 25 Apr 2020 09:43:00 +0300 [thread overview]
Message-ID: <20200425064300.zj6lmkhma65ene6s@tkn_work_nb> (raw)
In-Reply-To: <20200424072432.wxuuwnl3wavlycfj@tarantool.org>
On Fri, Apr 24, 2020 at 10:24:32AM +0300, Kirill Yukhin wrote:
> Hello,
>
> On 21 апр 20:44, Leonid Vasiliev wrote:
> > The cbus hang test uses glibc pthread mutex implementation details.
> > Therefore, it should not compile in case of using another library.
> > ---
> > Now the compilation for alpine 3.5 is broken.
> >
> > https://github.com/tarantool/tarantool/tree/lvasiliev/gh-noticket-glibc-check
> >
> > test/unit/CMakeLists.txt | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> I've checked your patch into master.
I had urge to push it downward to 1.10, but found that you already did
this (except EOL 2.1 and 2.2).
So now the build should pass on Alpine on all alive tarantool versions.
This is nice.
WBR, Alexander Turenko.
prev parent reply other threads:[~2020-04-25 6:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 17:44 Leonid Vasiliev
2020-04-22 14:20 ` Cyrill Gorcunov
2020-04-22 14:52 ` lvasiliev
2020-04-22 15:36 ` Cyrill Gorcunov
2020-04-23 9:10 ` lvasiliev
2020-04-23 9:26 ` Cyrill Gorcunov
2020-04-23 10:52 ` Alexander Turenko
2020-04-23 11:37 ` lvasiliev
2020-04-24 7:24 ` Kirill Yukhin
2020-04-24 8:02 ` Kirill Yukhin
2020-04-25 6:43 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425064300.zj6lmkhma65ene6s@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Add a check whether glibc is used' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox