From: Kirill Yukhin <kyukhin@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] cbus: fix inconsistency in endpoint creation
Date: Fri, 24 Apr 2020 10:57:15 +0300 [thread overview]
Message-ID: <20200424075714.g4tosz6q57r6jazl@tarantool.org> (raw)
In-Reply-To: <20200422195658.14170-1-gorcunov@gmail.com>
Hello,
On 22 апр 22:56, Cyrill Gorcunov wrote:
> The notification of wait variable shall be done under
> a bound mutex locked. Otherwise the results are not
> guaranteed (see pthread manuals).
>
> Thus when we create a new endpoint via cbus_endpoint_create
> and there is an other thread which sleeps inside cpipe_create
> we should notify the sleeper under cbus.mutex.
>
> Fixes #4806
>
> Reported-by: Alexander Turenko <alexander.turenko@tarantool.org>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
LGTM.
I've checked your patch into 1.10, 2.3, 2.4 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-04-24 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 19:56 Cyrill Gorcunov
2020-04-24 7:57 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424075714.g4tosz6q57r6jazl@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] cbus: fix inconsistency in endpoint creation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox