Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] replication: list anonymous replicas in box.info.replication
Date: Thu, 23 Apr 2020 17:06:04 +0300	[thread overview]
Message-ID: <20200423140604.GB19129@atlas> (raw)
In-Reply-To: <20200423130154.23910-1-sergepetrenko@tarantool.org>

* Serge Petrenko <sergepetrenko@tarantool.org> [20/04/23 16:05]:
> A new field is added to replica info in `box.info.replication` output:
> `anon`. The field is boolean and set to `true` for anonymous replicas
> and to `false` for normal replicas.
> 
> Also now anonymous replicas are listed in `box.info.replication`
> together with normal ones, so it's easier to track their connection
> state. Anonymous replicas occupy table slots past the biggest-id normal
> replica. Example:
> ```
> ...
>   replication:
>     1:
>       id: 1
>       uuid: 326eb713-1b79-4b43-9b48-661314260c61
>       lsn: 4
>       anon: false
>     2:

^^^^^^^ This is not an ordinal number, it's server id.

An anonymous replica doesn't have server id.

Why do you think assigning an unused id is a good idea? This will
break monitoring which may rely on server id being stable.

-- 
Konstantin Osipov, Moscow, Russia

      reply	other threads:[~2020-04-23 14:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 13:01 Serge Petrenko
2020-04-23 14:06 ` Konstantin Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200423140604.GB19129@atlas \
    --to=kostja.osipov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] replication: list anonymous replicas in box.info.replication' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox