Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Add a check whether glibc is used
Date: Thu, 23 Apr 2020 13:52:02 +0300	[thread overview]
Message-ID: <20200423105202.megr2ezi4upvjale@tkn_work_nb> (raw)
In-Reply-To: <41a1decbbad25ee4b080052e64f65d1c4206c426.1587490798.git.lvasiliev@tarantool.org>

LGTM.

Several minor comments are below.

> Add a check whether glibc is used

Please, add 'build' prefix.

On Tue, Apr 21, 2020 at 08:44:57PM +0300, Leonid Vasiliev wrote:
> The cbus hang test uses glibc pthread mutex implementation details.
> Therefore, it should not compile in case of using another library.

Reviewed-by: Alexander Turenko <alexander.turenko@tarantool.org>

> ---
> Now the compilation for alpine 3.5 is broken.

It worth to include certain motivation right into the commit message:
fix compilation on Alpine 3.5 is this case.

> 
> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-noticket-glibc-check

I would check it on '-full-ci' branch just in case.

> 
>  test/unit/CMakeLists.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/test/unit/CMakeLists.txt b/test/unit/CMakeLists.txt
> index 24586c2..699cd8c 100644
> --- a/test/unit/CMakeLists.txt
> +++ b/test/unit/CMakeLists.txt
> @@ -104,7 +104,9 @@ target_link_libraries(cbus_stress.test core stat)
>  add_executable(cbus.test cbus.c)
>  target_link_libraries(cbus.test core unit stat)
>  
> -if (${CMAKE_HOST_SYSTEM_NAME} MATCHES "Linux")
> +include(CheckSymbolExists)
> +check_symbol_exists(__GLIBC__ stdio.h GLIBC_USED)

On my system the macro is defined in features.h.

> +if (GLIBC_USED)
>      add_executable(cbus_hang.test cbus_hang.c)
>      target_link_libraries(cbus_hang.test core unit stat)
>  endif ()

  parent reply	other threads:[~2020-04-23 10:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 17:44 Leonid Vasiliev
2020-04-22 14:20 ` Cyrill Gorcunov
2020-04-22 14:52   ` lvasiliev
2020-04-22 15:36     ` Cyrill Gorcunov
2020-04-23  9:10       ` lvasiliev
2020-04-23  9:26         ` Cyrill Gorcunov
2020-04-23 10:52 ` Alexander Turenko [this message]
2020-04-23 11:37   ` lvasiliev
2020-04-24  7:24 ` Kirill Yukhin
2020-04-24  8:02   ` Kirill Yukhin
2020-04-25  6:43   ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200423105202.megr2ezi4upvjale@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=lvasiliev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] Add a check whether glibc is used' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox