From: Igor Munkin <imun@tarantool.org>
To: sergeyb@tarantool.org
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org,
v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 8/10] schema: fix internal symbols dangling in _G
Date: Tue, 21 Apr 2020 22:52:31 +0300 [thread overview]
Message-ID: <20200421195231.GE8314@tarantool.org> (raw)
In-Reply-To: <a82d9b282e5db48e870221d0316823898afcd33b.1587476678.git.sergeyb@tarantool.org>
Vlad,
Thanks for the patch! LGTM (feel free to push out of order as obvious).
Side note: I don't know whether we need a test for it (a simple lookup
for <update_format> and <role_check_grant_revoke_of_sys_priv> in _G) but
on the second thought it looks excess and out of the common practice.
On 21.04.20, sergeyb@tarantool.org wrote:
> From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
>
> A couple of functions were mistakenly declared as 'function'
> instead of 'local function' in schema.lua. That led to their
> presence in the global namespace.
> ---
> src/box/lua/schema.lua | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
<snipped>
> --
> 2.23.0
>
--
Best regards,
IM
next prev parent reply other threads:[~2020-04-21 19:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 14:00 [Tarantool-patches] [PATCH v4 0/10] Add static analysis with luacheck sergeyb
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 1/10] Add initial luacheck config sergeyb
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 2/10] gitlab-ci: enable static analysis with luacheck sergeyb
2020-04-21 20:04 ` Alexander Tikhonov
2020-04-22 8:09 ` Sergey Bronnikov
2020-04-22 8:11 ` Kirill Yukhin
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 3/10] Fix luacheck warnings in extra/dist/tarantoolctl.in sergeyb
2020-04-23 11:40 ` Igor Munkin
2020-04-24 8:02 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 4/10] Fix luacheck warnings in src/lua/ sergeyb
2020-04-23 14:13 ` Igor Munkin
2020-04-24 9:12 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 5/10] Fix luacheck warnings in src/box/lua/ sergeyb
2020-04-23 22:54 ` Igor Munkin
2020-05-07 10:32 ` Sergey Bronnikov
2020-05-07 14:34 ` Sergey Bronnikov
2020-05-07 10:52 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 6/10] Fix luacheck warnings in test/ sergeyb
2020-04-27 14:38 ` Igor Munkin
2020-05-06 16:16 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 7/10] schema: fix index promotion to functional index sergeyb
2020-04-23 23:24 ` Igor Munkin
2020-04-23 23:29 ` Igor Munkin
2020-04-28 23:19 ` Vladislav Shpilevoy
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 8/10] schema: fix internal symbols dangling in _G sergeyb
2020-04-21 14:13 ` Oleg Babin
2020-04-21 14:45 ` Sergey Bronnikov
2020-04-21 19:52 ` Igor Munkin [this message]
2020-04-23 23:27 ` Igor Munkin
2020-04-28 23:19 ` Vladislav Shpilevoy
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 9/10] Disabled test/luajit-tap in luacheckrc sergeyb
2020-04-24 10:16 ` Igor Munkin
2020-04-29 14:25 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck sergeyb
2020-04-21 19:33 ` Igor Munkin
2020-04-22 10:14 ` Sergey Bronnikov
2020-04-23 6:24 ` Sergey Bronnikov
2020-04-23 10:03 ` Igor Munkin
2020-04-23 10:30 ` Sergey Bronnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421195231.GE8314@tarantool.org \
--to=imun@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 8/10] schema: fix internal symbols dangling in _G' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox