From: sergeyb@tarantool.org
To: tarantool-patches@dev.tarantool.org, imun@tarantool.org,
v.shpilevoy@tarantool.org
Cc: o.piskunov@tarantool.org
Subject: [Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck
Date: Tue, 21 Apr 2020 17:00:27 +0300 [thread overview]
Message-ID: <20200421140258.42949-1-sergeyb@tarantool.org> (raw)
In-Reply-To: <cover.1587476678.git.sergeyb@tarantool.org>
From: Sergey Bronnikov <sergeyb@tarantool.org>
---
.../lj-494-table-chain-infinite-loop.test.lua | 26 +++++++++----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/test/lj-494-table-chain-infinite-loop.test.lua b/test/lj-494-table-chain-infinite-loop.test.lua
index 0daeca3..314eb29 100755
--- a/test/lj-494-table-chain-infinite-loop.test.lua
+++ b/test/lj-494-table-chain-infinite-loop.test.lua
@@ -16,7 +16,7 @@ ffi.cdef("char* strstr(const char*, const char*)")
local strstr = ffi.C.strstr
local cast = ffi.cast
local str_hash_offset = cast("uint32_t*", strstr("*", ""))[-2] == 1 and 3 or 2
-function str_hash(s)
+local function str_hash(s)
return cast("uint32_t*", strstr(s, "")) - str_hash_offset
end
local table_new = require("table.new")
@@ -25,17 +25,17 @@ local table_new = require("table.new")
local victims = {}
local orig_hash = {}
for c in ("abcdef"):gmatch"." do
- v = c .. "{09add58a-13a4-44e0-a52c-d44d0f9b2b95}"
+ local v = c .. "{09add58a-13a4-44e0-a52c-d44d0f9b2b95}"
victims[c] = v
orig_hash[c] = str_hash(v)[0]
end
collectgarbage()
do --- Basic version of the problem
- for k, v in pairs(victims) do
+ for _, v in pairs(victims) do
str_hash(v)[0] = 0
end
- t = table_new(0, 8)
+ local t = table_new(0, 8)
-- Make chain a -> b -> c -> d, all with a as primary
t[victims.a] = true
t[victims.d] = true
@@ -59,10 +59,10 @@ end
collectgarbage()
do --- Just `mn != freenode` can lead to infinite loops
- for k, v in pairs(victims) do
+ for _, v in pairs(victims) do
str_hash(v)[0] = 0
end
- t = table_new(0, 8)
+ local t = table_new(0, 8)
-- Make chain a -> b -> c -> d, all with a as primary
t[victims.a] = true
t[victims.d] = true
@@ -85,10 +85,10 @@ end
collectgarbage()
do --- Just `mn != nn` can lead to infinite loops
- for k, v in pairs(victims) do
+ for _, v in pairs(victims) do
str_hash(v)[0] = 0
end
- t = table_new(0, 8)
+ local t = table_new(0, 8)
-- Make chain a -> b -> c -> d -> e, all with a as primary
t[victims.a] = true
t[victims.e] = true
@@ -113,10 +113,10 @@ end
for i = 0, 10 do --- Non-strings can need rechaining too
collectgarbage()
- k = tonumber((("0x%xp-1074"):format(i)))
+ local k = tonumber((("0x%xp-1074"):format(i)))
str_hash(victims.a)[0] = 0
str_hash(victims.b)[0] = 0
- t = table_new(0, 4)
+ local t = table_new(0, 4)
-- a -> b, both with a as primary
t[victims.a] = true
t[victims.b] = true
@@ -140,10 +140,10 @@ end
for i = 0, 10 do --- Non-strings can be moved to freenode
collectgarbage()
- k = false
+ local k = false
str_hash(victims.a)[0] = 0
str_hash(victims.b)[0] = 0
- t = table_new(0, 4)
+ local t = table_new(0, 4)
-- a -> k -> b, all with a as primary
t[victims.a] = true
t[victims.b] = true
@@ -160,7 +160,7 @@ end
collectgarbage()
do --- Do not forget to advance freenode in the not-string case
- t = table_new(0, 4)
+ local t = table_new(0, 4)
-- Chain of colliding numbers
t[0x0p-1074] = true
t[0x4p-1074] = true
--
2.18.2
next prev parent reply other threads:[~2020-04-21 14:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 14:00 [Tarantool-patches] [PATCH v4 0/10] Add static analysis with luacheck sergeyb
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 1/10] Add initial luacheck config sergeyb
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 2/10] gitlab-ci: enable static analysis with luacheck sergeyb
2020-04-21 20:04 ` Alexander Tikhonov
2020-04-22 8:09 ` Sergey Bronnikov
2020-04-22 8:11 ` Kirill Yukhin
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 3/10] Fix luacheck warnings in extra/dist/tarantoolctl.in sergeyb
2020-04-23 11:40 ` Igor Munkin
2020-04-24 8:02 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 4/10] Fix luacheck warnings in src/lua/ sergeyb
2020-04-23 14:13 ` Igor Munkin
2020-04-24 9:12 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 5/10] Fix luacheck warnings in src/box/lua/ sergeyb
2020-04-23 22:54 ` Igor Munkin
2020-05-07 10:32 ` Sergey Bronnikov
2020-05-07 14:34 ` Sergey Bronnikov
2020-05-07 10:52 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 6/10] Fix luacheck warnings in test/ sergeyb
2020-04-27 14:38 ` Igor Munkin
2020-05-06 16:16 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 7/10] schema: fix index promotion to functional index sergeyb
2020-04-23 23:24 ` Igor Munkin
2020-04-23 23:29 ` Igor Munkin
2020-04-28 23:19 ` Vladislav Shpilevoy
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 8/10] schema: fix internal symbols dangling in _G sergeyb
2020-04-21 14:13 ` Oleg Babin
2020-04-21 14:45 ` Sergey Bronnikov
2020-04-21 19:52 ` Igor Munkin
2020-04-23 23:27 ` Igor Munkin
2020-04-28 23:19 ` Vladislav Shpilevoy
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 9/10] Disabled test/luajit-tap in luacheckrc sergeyb
2020-04-24 10:16 ` Igor Munkin
2020-04-29 14:25 ` Sergey Bronnikov
2020-04-21 14:00 ` sergeyb [this message]
2020-04-21 19:33 ` [Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck Igor Munkin
2020-04-22 10:14 ` Sergey Bronnikov
2020-04-23 6:24 ` Sergey Bronnikov
2020-04-23 10:03 ` Igor Munkin
2020-04-23 10:30 ` Sergey Bronnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421140258.42949-1-sergeyb@tarantool.org \
--to=sergeyb@tarantool.org \
--cc=imun@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox