From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] replication: remove unnecessary errors on replicating from an anonymous instance
Date: Mon, 20 Apr 2020 22:29:19 +0300 [thread overview]
Message-ID: <20200420192919.GZ3072@uranus> (raw)
In-Reply-To: <20200420131115.42047-1-sergepetrenko@tarantool.org>
On Mon, Apr 20, 2020 at 04:11:15PM +0300, Serge Petrenko wrote:
> Since the anonymous replica implementation, it was forbidden to
> replicate (join/subscribe/register) from anonymous instances.
> Actually, only joining and register should be banned. Anonymous replica
> isn't able to register its peer in _cluster anyway.
> Allow subscribing to anonymous instances and remove all the errors
> mentioning unsupported replication from anonymous replica. Join and
> register are covered by ER_READONLY errors, since anonymous replicas
> must be read-only.
>
> Closes #4696
> ---
I don't see any obvious errors here. Still I'm far from being repication
expert. So I can put
Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
only.
next prev parent reply other threads:[~2020-04-20 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 13:11 Serge Petrenko
2020-04-20 19:29 ` Cyrill Gorcunov [this message]
2020-04-28 20:55 ` Vladislav Shpilevoy
2020-05-06 10:08 ` Serge Petrenko
2020-05-06 21:51 ` Vladislav Shpilevoy
2020-05-07 10:33 ` Serge Petrenko
2020-05-07 21:53 ` Vladislav Shpilevoy
2020-05-08 11:16 ` Serge Petrenko
2020-05-10 19:43 ` Vladislav Shpilevoy
2020-05-15 14:37 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420192919.GZ3072@uranus \
--to=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] replication: remove unnecessary errors on replicating from an anonymous instance' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox