Re: [Tarantool-patches] [PATCH v2 0/2] Stacked diagnostic area follow-ups

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 17 апр 23:16, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-4887-ref-error-on-prev
> Issue: https://github.com/tarantool/tarantool/issues/4887
> 
> Changes in v2:
> 
>  - modified test so that now it uses weak references to check that
> gc collected error objects (i.e. there's no memory leaks);
>  - added overflow check in error_ref() so that after 2^32 calls
> of box.error.last() or error:prev() error object won't contain
> broken reference counter.
> 
> Nikita Pettik (2):
>   box/error: don't allow overflow of error ref counter
>   box/error: ref error.prev while accessing it

I've checked your patchset into master.

However, looks like it'd be better to just replace int32 to
int64 and avoid problems if GC64.

Since I've already checked the patch in, could you please
prepare a patch which will revert functional changes of 2/2
and use int64 instead?

--
Regards, Kirill Yukhin