From: Kirill Yukhin <kyukhin@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] libev: unlimited select flag did not work on mac
Date: Mon, 20 Apr 2020 10:59:09 +0300 [thread overview]
Message-ID: <20200420075908.rdgv4bnatu4hp3q2@tarantool.org> (raw)
In-Reply-To: <20200420063050.twyrcveukpfwt7cu@tkn_work_nb>
Hello,
On 20 апр 09:30, Alexander Turenko wrote:
> On Mon, Feb 17, 2020 at 10:40:52AM +0300, Konstantin Osipov wrote:
> > * Alexander Turenko <alexander.turenko@tarantool.org> [20/02/15 23:22]:
> > > > Is it fixed in the upstream? Why is noone complaining in the
> > > > upstream? Is there a bug in the upstream?
> > >
> > > Let me read changelog for you:
> >
> > Well, I guess the commit comment should say that this is only an
> > update from the upstream.
> >
> > Let me read third_party/README for you!
> >
> > How to update libev
> > ===================
> >
> > Remove Tarantool patches (see csv diff -U8).
> > cvs up
> > Add patches back.
> >
> > Did the patch follow the procedure? If it did, it should clearly
> > state that it updated libev, and to which version.
>
> This have sense.
>
> But I would include the backport of the fix in the upcoming release.
>
> Pushed to Totktonada/gh-3867-fix-select-on-mac-os-full-ci and shown
> below.
I've checked your patch into 1.10, 2.2, 2.3 and master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-04-20 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 18:45 Maria Khaydich
2020-02-13 0:14 ` Vladislav Shpilevoy
2020-02-15 17:50 ` Konstantin Osipov
2020-02-15 20:19 ` Alexander Turenko
2020-02-17 7:40 ` Konstantin Osipov
2020-02-17 10:00 ` Alexander Turenko
2020-03-03 14:58 ` [Tarantool-patches] [PATCH] libev: update to version 4.32 Maria Khaydich
2020-04-20 6:30 ` [Tarantool-patches] [PATCH] libev: unlimited select flag did not work on mac Alexander Turenko
2020-04-20 7:59 ` Kirill Yukhin [this message]
2020-04-21 17:01 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420075908.rdgv4bnatu4hp3q2@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] libev: unlimited select flag did not work on mac' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox