From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] box/error: don't allow overflow of error ref counter
Date: Mon, 20 Apr 2020 01:15:37 +0000 [thread overview]
Message-ID: <20200420011537.GB25021@tarantool.org> (raw)
In-Reply-To: <0c99f856-c946-06bc-e87a-a95a87ea6eaa@tarantool.org>
On 18 Apr 01:54, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> Maybe just make the ref counter uint64_t? It will never
> overflow then, and the patch would become of 2 lines.
"Explicit is better than implicit", so I'd prefer explicit error
raising rather than silent reducing counter modulo 2^64.
What is more, making counter unsigned still don't resolve all
problems: reset would result in premature error destruction
meanwhile some Lua object still accessing it.
next prev parent reply other threads:[~2020-04-20 1:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 20:16 [Tarantool-patches] [PATCH v2 0/2] Stacked diagnostic area follow-ups Nikita Pettik
2020-04-17 20:16 ` [Tarantool-patches] [PATCH v2 1/2] box/error: don't allow overflow of error ref counter Nikita Pettik
2020-04-17 23:54 ` Vladislav Shpilevoy
2020-04-20 1:15 ` Nikita Pettik [this message]
2020-04-17 20:16 ` [Tarantool-patches] [PATCH v2 2/2] box/error: ref error.prev while accessing it Nikita Pettik
2020-04-20 14:22 ` [Tarantool-patches] [PATCH v2 0/2] Stacked diagnostic area follow-ups Kirill Yukhin
2020-04-20 14:35 ` Nikita Pettik
2020-04-20 15:29 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420011537.GB25021@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] box/error: don'\''t allow overflow of error ref counter' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox