From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] net.box: fix fetching of schema of an old version
Date: Sun, 19 Apr 2020 19:23:27 +0300 [thread overview]
Message-ID: <20200419162327.6hwg7xm4l75izzur@tkn_work_nb> (raw)
In-Reply-To: <26e71870-33fa-9ec2-2493-d565dbc9d0e7@tarantool.org>
> > It seems logical to move snapshots out from test suites, since they will
> > be used across the test suites. What do you think?
>
> It is not always the case. A snapshot is ok to use across tests only if
> it is not related to any particular test more than to others. Only empty
> snapshots satisfy that criteria. The reason is that we are obligated to
> keep tests isolated from each other. And if you use one non-empty snapshot
> for multiple tests, the policy will be violated.
(Continued snap/upgrade discussion in the sibling email thread.)
How about this directory structure?
test/
|
+- snap/
|
+- how_to_add_new_test.md
|
+- xlog/
| |
| +- gh-4771-upgrade-sequence/
| |
| +- fill.lua
| +- 2.1.3/
| |
| +- *.snap
|
+- box-tap/
|
+- gh-4691-net-box-connect-schema-2-1-3/
|
+- fill.lua
+- 2.1.3/
|
+- *.snap
Key points:
* All snapshots are in one place: it is easier to keep them right
structured.
* Snapshots are organized on per-test basis.
Alternative:
test/
|
+- xlog/
| |
| +- snap/
| |
| +- how_to_add_new_test.md
| |
| +- gh-4771-upgrade-sequence/
| |
| +- fill.lua
| +- 2.1.3/
| |
| +- *.snap
|
+- box-tap/
|
+- snap/
|
+- how_to_add_new_test.md -> ../../xlog/snap/how_to_add_new_test.md
|
+- gh-4691-net-box-connect-schema-2-1-3/
|
+- fill.lua
+- 2.1.3/
|
+- *.snap
Key points:
* All snapshots organized as same structured subtrees.
* Same as above, snapshots are organized on per-test basis.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2020-04-19 16:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 20:45 Alexander Turenko
2020-04-02 21:20 ` Alexander Turenko
2020-04-03 22:53 ` Vladislav Shpilevoy
2020-04-03 23:38 ` Alexander Turenko
2020-04-04 17:40 ` Vladislav Shpilevoy
2020-04-05 12:05 ` Alexander Turenko
2020-04-05 16:41 ` Vladislav Shpilevoy
2020-04-06 11:39 ` Alexander Turenko
2020-04-09 21:30 ` Vladislav Shpilevoy
2020-04-19 16:23 ` Alexander Turenko [this message]
2020-04-19 17:02 ` Vladislav Shpilevoy
2020-04-19 16:22 ` Alexander Turenko
2020-04-19 17:02 ` Vladislav Shpilevoy
2020-04-20 6:58 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419162327.6hwg7xm4l75izzur@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] net.box: fix fetching of schema of an old version' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox