From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] net.box: fix fetching of schema of an old version
Date: Sun, 19 Apr 2020 19:22:45 +0300 [thread overview]
Message-ID: <20200419162245.3gi4l43ye4ypkw5e@tkn_work_nb> (raw)
In-Reply-To: <20200406113935.fu3zli6s5x4dusgb@tkn_work_nb>
On Mon, Apr 06, 2020 at 02:39:37PM +0300, Alexander Turenko wrote:
> > >> The test and the bug are still upgrade related. 'xlog/upgrade' is not
> > >> called 'xlog/upgrade_called'. It is called just 'upgrade'. For all cases
> > >> when an old snapshot is used to start a new tarantool.
> > >
> > > I disagree here. 'upgrade' is not something about working upward an old
> > > snapshot.
> >
> > It is. Because you won't work on the old snapshot forever. You are
> > going to upgrade anyway. Your bug is for when upgrade is started but
> > not finished. Because Tarantools are new, but upgrade() is not called
> > yet.
>
> It is like "sooner or later a user will use feature X after Y, so let's
> call Y as X". I understood your point, but still think that the name
> 'upgrade' is misleading. More general 'snap' or 'snapshots' looks better
> for me.
>
> In fact upgrade may break old connectors (say, due to unicode_ci
> collation of _func on 2.2) and I guess the old schema may be kept for
> quite long time so.
We should agree on some name for directory(-ies) with snapshots for
testing purposes.
I think that stored snapshots may be used to test various scenarious:
* Start from a snapshot with old schema and data, then call upgrade and
test a scenario.
* Start from a snapshot with old schema and some data, then test a
scenario.
* Start from a snapshot that is broken by a past upgrade (see #4804),
then test a scenario.
* Start from a broken snapshot and test a scenario:
- A snapshot that violates some constraint (and so is hard to be
generated on demand), see #4797.
- A snapshot that has broken metainformation: instance uuid, vclock.
So I would prefer a name that is more general then 'upgrade': 'snap',
'snapshots'.
Aren't this convince you?
WBR, Alexander Turenko.
next prev parent reply other threads:[~2020-04-19 16:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 20:45 Alexander Turenko
2020-04-02 21:20 ` Alexander Turenko
2020-04-03 22:53 ` Vladislav Shpilevoy
2020-04-03 23:38 ` Alexander Turenko
2020-04-04 17:40 ` Vladislav Shpilevoy
2020-04-05 12:05 ` Alexander Turenko
2020-04-05 16:41 ` Vladislav Shpilevoy
2020-04-06 11:39 ` Alexander Turenko
2020-04-09 21:30 ` Vladislav Shpilevoy
2020-04-19 16:23 ` Alexander Turenko
2020-04-19 17:02 ` Vladislav Shpilevoy
2020-04-19 16:22 ` Alexander Turenko [this message]
2020-04-19 17:02 ` Vladislav Shpilevoy
2020-04-20 6:58 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419162245.3gi4l43ye4ypkw5e@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] net.box: fix fetching of schema of an old version' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox