From: Igor Munkin <imun@tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in src/lua/
Date: Fri, 17 Apr 2020 15:13:43 +0300 [thread overview]
Message-ID: <20200417121343.GN8314@tarantool.org> (raw)
In-Reply-To: <20200417092655.GC115@pony.bronevichok.ru>
Sergey,
On 17.04.20, Sergey Bronnikov wrote:
> Igor, thanks for review!
> See my answers below.
>
> On 23:51 Wed 15 Apr , Igor Munkin wrote:
> > Sergey,
> >
> > Thanks for the patch!
> >
<snipped>
> > I see no reasons to leave other W212[unused argument self] occurences.
> > Here is a diff:
>
> Vladislav already told me in previous review iterations that '_' is less
> readable than 'self', so it was a reason why haven't fixed them. I have
> found a way to supress only W212 related to 'self' and applied it in
> branch.
Nice! That's exactly what we need for this issue!
>
> S.
--
Best regards,
IM
next prev parent reply other threads:[~2020-04-17 12:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 7:55 [Tarantool-patches] [PATCH v3 0/6] Add static analysis with luacheck Sergey Bronnikov
2020-04-14 7:56 ` [Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in src/lua/ Sergey Bronnikov
2020-04-14 23:29 ` Vladislav Shpilevoy
2020-04-15 20:51 ` Igor Munkin
2020-04-15 21:40 ` Vladislav Shpilevoy
2020-04-17 9:07 ` Sergey Bronnikov
2020-04-17 9:09 ` Sergey Bronnikov
2020-04-15 20:51 ` Igor Munkin
2020-04-15 21:46 ` Vladislav Shpilevoy
2020-04-16 13:52 ` Igor Munkin
2020-04-17 9:26 ` Sergey Bronnikov
2020-04-17 12:13 ` Igor Munkin [this message]
2020-04-14 7:57 ` [Tarantool-patches] [PATCH 2/6] Fix luacheck warnings in test/ Sergey Bronnikov
2020-04-14 23:29 ` Vladislav Shpilevoy
2020-04-17 12:05 ` Igor Munkin
2020-04-17 19:51 ` Sergey Bronnikov
2020-04-17 19:47 ` Sergey Bronnikov
2020-04-16 13:43 ` Igor Munkin
2020-04-14 7:57 ` [Tarantool-patches] [PATCH 3/6] Fix luacheck warnings in src/box/lua/ Sergey Bronnikov
2020-04-14 23:30 ` Vladislav Shpilevoy
2020-04-14 7:58 ` [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in extra/dist/tarantoolctl.in Sergey Bronnikov
2020-04-14 23:30 ` Vladislav Shpilevoy
2020-04-15 15:35 ` Igor Munkin
2020-04-14 8:01 ` [Tarantool-patches] [PATCH 5/6] Add luacheck config Sergey Bronnikov
2020-04-14 23:30 ` Vladislav Shpilevoy
2020-04-14 8:01 ` [Tarantool-patches] [PATCH 6/6] gitlab-ci: enable static analysis with luacheck Sergey Bronnikov
2020-04-14 23:30 ` [Tarantool-patches] [PATCH v3 7/6] schema: fix index promotion to functional index Vladislav Shpilevoy
2020-04-14 23:30 ` [Tarantool-patches] [PATCH v3 8/6] schema: fix internal symbols dangling in _G Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417121343.GN8314@tarantool.org \
--to=imun@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in src/lua/' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox