Re: [Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in src/lua/

[Sergey Bronnikov <sergeyb@tarantool.org>]

Igor, thanks for review!
See my answers below.

On 23:51 Wed 15 Apr , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch!
> 
> On 14.04.20, Sergey Bronnikov wrote:
> > Many warnings fixed with help from Vladislav Shpilevoy.

<snipped>

> > diff --git a/src/lua/argparse.lua b/src/lua/argparse.lua
> > index faa0ae130..f58985425 100644
> > --- a/src/lua/argparse.lua
> > +++ b/src/lua/argparse.lua
> > @@ -90,8 +90,8 @@ local function convert_parameter(name, convert_from, convert_to)
> >      return convert_from
> >  end
> >  
> > -local function parameters_parse(t_in, options)
> > -    local t_out, t_in = {}, t_in or {}
> > +local function parameters_parse(t__in, options)
> > +    local t_out, t_in = {}, t__in or {}
> 
> I guess you can just give t__in a proper name, e.g. args, params, etc.

Agree with you, replaced it with 'param'.

<snipped>

> I see no reasons to leave other W212[unused argument self] occurences.
> Here is a diff:

Vladislav already told me in previous review iterations that '_' is less
readable than 'self', so it was a reason why haven't fixed them. I have
found a way to supress only W212 related to 'self' and applied it in
branch.

S.