Re: [Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in src/lua/

[Sergey Bronnikov <sergeyb@tarantool.org>]

Igor,

thanks a lot for review. See my answers below.

On 23:51 Wed 15 Apr , Igor Munkin wrote:

<snipped>

> > ====================
> > 
> >     Review fixes: src/lua
> > 
> > diff --git a/src/lua/fiber.lua b/src/lua/fiber.lua
> > index 89c17f63d..692408e54 100644
> > --- a/src/lua/fiber.lua
> > +++ b/src/lua/fiber.lua
> > @@ -40,7 +40,7 @@ fiber.stall = nil
> >  
> >  local worker_next_task = nil
> >  local worker_last_task = nil
> 
> It looks like this assignment can also be omitted (anyway luacheck also
> reports it as a warning).

Kept it as is because luacheck don't warn me about it.

> > -local worker_fiber = nil
> > +local worker_fiber
> >  
> >  --
> >  -- Worker is a singleton fiber for not urgent delayed execution of
> 
> <snipped>
> 
> > diff --git a/src/lua/msgpackffi.lua b/src/lua/msgpackffi.lua
> > index 9105c3f23..793f47854 100644
> > --- a/src/lua/msgpackffi.lua
> > +++ b/src/lua/msgpackffi.lua
> > @@ -501,7 +501,11 @@ local ext_decoder = {
> >      -- MP_DECIMAL
> >      [1] = function(data, len) local num = ffi.new("decimal_t") builtin.decimal_unpack(data, len, num) return num end,
> 
> I guess MP_DECIMAL decoder can also be transformed to multiline function.

The same - kept it as is because luacheck don't warn me about it.

S.