Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH V4 4/6] error: add session setting for error type marshaling
Date: Fri, 17 Apr 2020 10:35:40 +0300	[thread overview]
Message-ID: <20200417073540.GA4007@atlas> (raw)
In-Reply-To: <4ff74326-f83d-599d-fcda-c7d8175c9263@tarantool.org>

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [20/04/17 10:16]:
> Seems like you are talking about the case when error object is
> thrown as an exception. But the patchset is about being able to
> recognize and decode errors even when they are returned inside
> response body, as a part of IPROTO_OK response type.

Then you think this justifies inventing a custom marshalling
scheme and thus forcing all clients to not just patch the driver
but also patch or even re-implement msgpack library they use? 

Worse yet, with such a huge protocol change you can add complete
marshalling of any object - SQL parse tree, Lua thread along with
all its referenced objects, Lua code and stack data, and what not
-- all very desired for other features, like distributed SQL or 
shipping/executing Lua code close to data.

Worse *yet*, it's quite possible to add all these features without
an MP_EXT. But this doesn't concern you at all. 

So what about an RFC?

-- 
Konstantin Osipov, Moscow, Russia

  reply	other threads:[~2020-04-17  7:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 17:38 [Tarantool-patches] [PATCH V4 0/6] Extending error functionality Leonid Vasiliev
2020-04-16 17:38 ` [Tarantool-patches] [PATCH V4 1/6] error: add custom error type Leonid Vasiliev
2020-04-17  0:49   ` Vladislav Shpilevoy
2020-04-18 17:14     ` lvasiliev
2020-04-16 17:38 ` [Tarantool-patches] [PATCH V4 2/6] error: send custom type in IProto Leonid Vasiliev
2020-04-17  0:51   ` Vladislav Shpilevoy
2020-04-16 17:38 ` [Tarantool-patches] [PATCH V4 3/6] session: add offset to SQL session settings array Leonid Vasiliev
2020-04-16 17:38 ` [Tarantool-patches] [PATCH V4 4/6] error: add session setting for error type marshaling Leonid Vasiliev
2020-04-16 19:48   ` Konstantin Osipov
2020-04-17  0:51     ` Vladislav Shpilevoy
2020-04-17  7:35       ` Konstantin Osipov [this message]
2020-04-16 17:38 ` [Tarantool-patches] [PATCH V4 5/6] error: update constructors of some errors Leonid Vasiliev
2020-04-16 17:38 ` [Tarantool-patches] [PATCH V4 6/6] error: add error MsgPack encoding Leonid Vasiliev
2020-04-17  0:58   ` Vladislav Shpilevoy
2020-04-18 17:46     ` lvasiliev
2020-04-17  0:51 ` [Tarantool-patches] [PATCH V4 0/6] Extending error functionality Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417073540.GA4007@atlas \
    --to=kostja.osipov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH V4 4/6] error: add session setting for error type marshaling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox