Re: [Tarantool-patches] [PATCH 00/12] Popen Lua API: preliminary patches 2

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 14 апр 14:38, Alexander Turenko wrote:
> It is the second patchset of preparation patches that are needed to
> implement Lua API for popen.
> 
> See the previous series here (already pushed to master):
> https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/015609.html
> 
> https://github.com/tarantool/tarantool/issues/4031
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-4031-popen-lua-api-preparation-2
> 
> I also pushed the same commit to *-full-ci branch to verify it on all
> platforms:
> 
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-4031-popen-lua-api-preparation-2-full-ci
> 
> Alexander Turenko (10):
>   popen: log a reason of close inherited fds failure
>   popen: add missed diag_set() in popen_new()
>   popen: remove retval from popen_stat()
>   popen: quote multiword command arguments
>   popen: add logging of duplicated logger fd
>   popen: fix close-on-exec flag setting
>   popen: clarify popen_{signal,delete} contract
>   popen: add FIXME re group signal flaw
>   popen: clarify popen_read_timeout error message
>   popen: allow to close parent's end of std* fds
> 
> Cyrill Gorcunov (2):
>   popen: allow to kill process group
>   popen: add ability to keep child on deletion
> 
>  src/lib/core/popen.c | 305 +++++++++++++++++++++++++++++++++----------
>  src/lib/core/popen.h |  17 ++-
>  2 files changed, 253 insertions(+), 69 deletions(-)

I've checked your patch into master.

--
Regards, Kirill Yukhin