From: Nikita Pettik <korablev@tarantool.org> To: Mergen Imeev <imeevma@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1 1/1] lua: fix test sql/func-recreate.test.lua Date: Thu, 16 Apr 2020 22:04:16 +0000 [thread overview] Message-ID: <20200416220415.GC8455@tarantool.org> (raw) In-Reply-To: <20200416211547.GA19535@tarantool.org> On 17 Apr 00:15, Mergen Imeev wrote: > On Thu, Apr 16, 2020 at 09:02:05PM +0000, Nikita Pettik wrote: > > On 16 Apr 23:24, Mergen Imeev wrote: > > > Hi! Thank you for review. My answer below. > > > > > > On Thu, Apr 16, 2020 at 07:18:51PM +0000, Nikita Pettik wrote: > > > > On 16 Apr 22:09, Alexander Tikhonov wrote: > > > > > > > > > > Hi Mergen, thanks for the patch, I’ve checked it on 2.2 and it runs fine, patch LGTM. > > > > > > > > > > > > > Did you verify that modified test still reproduces initial problem? > > > > I hope so, but ask just in case. > > > According to history, the main goal of this part of the > > > test is to show that sql_create_function() throws proper > > > error in case a new function is created when transaction > > > is active. Since the error still here, we may say that > > > the test works. > > > > So the answer to my question is - no, you didn't test it. > > Better safe than sorry - I'd better verify that updated > > test still covers the initial problem. Thanks. > > > Doesn't my answer says that we checked it? No, it doesn't. 'reproduce' means that you are supposed to checkout to branch, revert particular fix, run updated test without that fix and verify that test fails without fix. Any other actions do not refer to my original question. >However, I agree that it is never wrong to check it again. Please, check it for current fix and for any other test upgrade in future.
next prev parent reply other threads:[~2020-04-16 22:04 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-16 19:07 imeevma 2020-04-16 19:09 ` Alexander Tikhonov 2020-04-16 19:18 ` Nikita Pettik 2020-04-16 19:33 ` Alexander Tikhonov 2020-04-16 20:24 ` Mergen Imeev 2020-04-16 21:02 ` Nikita Pettik 2020-04-16 21:15 ` Mergen Imeev 2020-04-16 22:04 ` Nikita Pettik [this message] 2020-04-17 6:05 ` Alexander Tikhonov 2020-04-17 12:45 ` Nikita Pettik 2020-04-17 14:18 ` Mergen Imeev 2020-04-17 15:50 ` Nikita Pettik 2020-04-17 6:25 ` Mergen Imeev 2020-04-17 6:31 ` Alexander Tikhonov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200416220415.GC8455@tarantool.org \ --to=korablev@tarantool.org \ --cc=imeevma@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 1/1] lua: fix test sql/func-recreate.test.lua' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox