From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] relay: move relay_schedule_pending_gc before status
Date: Thu, 16 Apr 2020 15:42:40 +0300 [thread overview]
Message-ID: <20200416124240.GT3072@uranus> (raw)
In-Reply-To: <20200416123802.GS3072@uranus>
On Thu, Apr 16, 2020 at 03:38:02PM +0300, Cyrill Gorcunov wrote:
...
> > This code was present in v5 of the patchset regarding local space replication
> > rework, but I accidentally threw it away during the review. Sorry.
> > The letter was "[PATCH v5 2/4] replication: hide 0-th vclock components in
> > replication responses"
> >
> > Branch: https://github.com/tarantool/tarantool/tree/sp/relay-gc-fix
>
> Maybe it worth to have two commits?
>
> - use vclock_compare_ignore0 in relay_schedule_pending_gc
> - reorder relay_schedule_pending_gc
Doesn't matter, already merged :)
next prev parent reply other threads:[~2020-04-16 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 12:06 [Tarantool-patches] [PATCH] relay: move relay_schedule_pending_gc before status update Serge Petrenko
2020-04-16 12:37 ` Kirill Yukhin
2020-04-16 12:38 ` Cyrill Gorcunov
2020-04-16 12:42 ` Cyrill Gorcunov [this message]
2020-04-17 7:02 ` [Tarantool-patches] [PATCH] relay: move relay_schedule_pending_gc before status Kirill Yukhin
2020-04-17 7:10 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416124240.GT3072@uranus \
--to=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] relay: move relay_schedule_pending_gc before status' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox