From: Sergey Ostanevich <sergos@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] lua: return getaddrinfo() errors
Date: Thu, 16 Apr 2020 13:27:50 +0300 [thread overview]
Message-ID: <20200416102750.GA3110@tarantool.org> (raw)
In-Reply-To: <E1BA97E1-B48D-42F5-B3F2-BE71EF15876B@tarantool.org>
On 06 апр 05:08, Roman Khabibov wrote:
> >> +test_run:cmd("setopt delimiter ';'")
> >> +function check_err(err)
> >> + if err == 'getaddrinfo: nodename nor servname provided, or not known' or
> >> + err == 'getaddrinfo: Servname not supported for ai_socktype' or
> >> + err == 'getaddrinfo: Name or service not known' or
> >> + err == 'getaddrinfo: hostname nor servname provided, or not known' or
> >> + err == 'getaddrinfo: Temporary failure in name resolution' or
> >> + err == 'getaddrinfo: Name could not be resolved at this time' then
> >> + return true
> >> + end
> >> + return false
> >> +end;
> > I really doubt that different error messages from the set above will appear
> > for the same error on different platforms. Could you please check for particular
> > output for each case you trigger below?
> Look at that:
> https://travis-ci.org/github/tarantool/tarantool/jobs/546115892#L3581 - Linux failed
> https://travis-ci.org/github/tarantool/tarantool/jobs/546115893#L3100 - macOS isn’t
>
Exactly, this means for the error EAI_NONAME those OSes have differnet
messages. But you've put different errors in one bunch - I meant it
should never return 'Temporary failure in name resolution' as a result
for EAI_SERVICE, right?
Are you testing for correct error returned for a particular case?
Otherwise looks good.
Sergos
next prev parent reply other threads:[~2020-04-16 10:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 10:24 [Tarantool-patches] [PATCH v2 0/2] Return " Roman Khabibov
2020-03-12 10:24 ` [Tarantool-patches] [PATCH v2 1/2] coio/say: fix getaddrinfo error handling on macOS Roman Khabibov
2020-03-29 8:51 ` Sergey Ostanevich
2020-03-29 9:12 ` Alexander Turenko
2020-04-06 2:07 ` Roman Khabibov
2020-04-17 9:37 ` Sergey Ostanevich
2020-04-24 11:32 ` Roman Khabibov
2020-06-23 13:27 ` Roman Khabibov
2020-07-23 14:12 ` Sergey Ostanevich
2020-07-28 9:26 ` Roman Khabibov
2020-04-26 17:20 ` Vladislav Shpilevoy
2020-03-12 10:24 ` [Tarantool-patches] [PATCH v2 2/2] lua: return getaddrinfo() errors Roman Khabibov
2020-03-29 9:07 ` Sergey Ostanevich
2020-03-29 9:25 ` Alexander Turenko
2020-04-06 2:08 ` Roman Khabibov
2020-04-16 10:27 ` Sergey Ostanevich [this message]
2020-04-24 11:42 ` Roman Khabibov
2020-04-24 17:18 ` Sergey Ostanevich
2020-04-26 3:16 ` Roman Khabibov
2020-04-26 15:46 ` Alexander Turenko
2020-04-26 16:26 ` Roman Khabibov
2020-07-13 9:51 ` sergos
2020-07-28 14:08 ` [Tarantool-patches] [PATCH v2 0/2] Return " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416102750.GA3110@tarantool.org \
--to=sergos@tarantool.org \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/2] lua: return getaddrinfo() errors' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox