[Tarantool-patches] [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco

[Tarantool-patches] [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco

[Alexander V. Tikhonov]

Removed Ubuntu 19.04 Disco from testing which is EOL.

Close #4896
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
Issue: https://github.com/tarantool/tarantool/issues/4896

 .gitlab-ci.yml | 12 ------------
 .travis.yml    |  3 ---
 2 files changed, 15 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index cd710027f..7710629e7 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -323,12 +323,6 @@ ubuntu_18_04:
     OS: 'ubuntu'
     DIST: 'bionic'
 
-ubuntu_19_04:
-  <<: *pack_definition
-  variables:
-    OS: 'ubuntu'
-    DIST: 'disco'
-
 ubuntu_19_10:
   <<: *pack_definition
   variables:
@@ -415,12 +409,6 @@ ubuntu_18_04_deploy:
     OS: 'ubuntu'
     DIST: 'bionic'
 
-ubuntu_19_04_deploy:
-  <<: *deploy_definition
-  variables:
-    OS: 'ubuntu'
-    DIST: 'disco'
-
 ubuntu_19_10_deploy:
   <<: *deploy_definition
   variables:
diff --git a/.travis.yml b/.travis.yml
index c63ab3ebd..41540fb79 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -67,9 +67,6 @@ jobs:
       - name: "Ubuntu Bionic (18.04) build + deploy DEB"
         env: OS=ubuntu DIST=bionic
         if: branch = "master"
-      - name: "Ubuntu Disco (19.04) build + deploy DEB"
-        env: OS=ubuntu DIST=disco
-        if: branch = "master"
       - name: "Ubuntu Eoan (19.10) build + deploy DEB"
         env: OS=ubuntu DIST=eoan
         if: branch = "master"
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco

[Oleg Piskunov]

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]


LGTM
  
>Среда, 15 апреля 2020, 16:32 +03:00 от Alexander V. Tikhonov <avtikhon@tarantool.org>:
> 
>Removed Ubuntu 19.04 Disco from testing which is EOL.
>
>Close #4896
>---
>
>Github:  https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
>Issue:  https://github.com/tarantool/tarantool/issues/4896
>
> .gitlab-ci.yml | 12 ------------
> .travis.yml | 3 ---
> 2 files changed, 15 deletions(-)
>
>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>index cd710027f..7710629e7 100644
>--- a/.gitlab-ci.yml
>+++ b/.gitlab-ci.yml
>@@ -323,12 +323,6 @@ ubuntu_18_04:
>     OS: 'ubuntu'
>     DIST: 'bionic'
> 
>-ubuntu_19_04:
>- <<: *pack_definition
>- variables:
>- OS: 'ubuntu'
>- DIST: 'disco'
>-
> ubuntu_19_10:
>   <<: *pack_definition
>   variables:
>@@ -415,12 +409,6 @@ ubuntu_18_04_deploy:
>     OS: 'ubuntu'
>     DIST: 'bionic'
> 
>-ubuntu_19_04_deploy:
>- <<: *deploy_definition
>- variables:
>- OS: 'ubuntu'
>- DIST: 'disco'
>-
> ubuntu_19_10_deploy:
>   <<: *deploy_definition
>   variables:
>diff --git a/.travis.yml b/.travis.yml
>index c63ab3ebd..41540fb79 100644
>--- a/.travis.yml
>+++ b/.travis.yml
>@@ -67,9 +67,6 @@ jobs:
>       - name: "Ubuntu Bionic (18.04) build + deploy DEB"
>         env: OS=ubuntu DIST=bionic
>         if: branch = "master"
>- - name: "Ubuntu Disco (19.04) build + deploy DEB"
>- env: OS=ubuntu DIST=disco
>- if: branch = "master"
>       - name: "Ubuntu Eoan (19.10) build + deploy DEB"
>         env: OS=ubuntu DIST=eoan
>         if: branch = "master"
>--
>2.17.1
>  
 
 
--
Oleg Piskunov
 

[-- Attachment #2: Type: text/html, Size: 2794 bytes --]

Re: [Tarantool-patches] [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco

[Sergey Bronnikov]

LGTM

On 16:32 Wed 15 Apr , Alexander V. Tikhonov wrote:
> Removed Ubuntu 19.04 Disco from testing which is EOL.
> 
> Close #4896
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4896
> 
>  .gitlab-ci.yml | 12 ------------
>  .travis.yml    |  3 ---
>  2 files changed, 15 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index cd710027f..7710629e7 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -323,12 +323,6 @@ ubuntu_18_04:
>      OS: 'ubuntu'
>      DIST: 'bionic'
>  
> -ubuntu_19_04:
> -  <<: *pack_definition
> -  variables:
> -    OS: 'ubuntu'
> -    DIST: 'disco'
> -
>  ubuntu_19_10:
>    <<: *pack_definition
>    variables:
> @@ -415,12 +409,6 @@ ubuntu_18_04_deploy:
>      OS: 'ubuntu'
>      DIST: 'bionic'
>  
> -ubuntu_19_04_deploy:
> -  <<: *deploy_definition
> -  variables:
> -    OS: 'ubuntu'
> -    DIST: 'disco'
> -
>  ubuntu_19_10_deploy:
>    <<: *deploy_definition
>    variables:
> diff --git a/.travis.yml b/.travis.yml
> index c63ab3ebd..41540fb79 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -67,9 +67,6 @@ jobs:
>        - name: "Ubuntu Bionic (18.04) build + deploy DEB"
>          env: OS=ubuntu DIST=bionic
>          if: branch = "master"
> -      - name: "Ubuntu Disco (19.04) build + deploy DEB"
> -        env: OS=ubuntu DIST=disco
> -        if: branch = "master"
>        - name: "Ubuntu Eoan (19.10) build + deploy DEB"
>          env: OS=ubuntu DIST=eoan
>          if: branch = "master"
> -- 
> 2.17.1
> 

-- 
sergeyb@

Re: [Tarantool-patches] [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco

[Kirill Yukhin]

Hello,

On 15 апр 16:32, Alexander V. Tikhonov wrote:
> Removed Ubuntu 19.04 Disco from testing which is EOL.
> 
> Close #4896
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4896

I've checked your patch into 1.10, 2.2, 2.3 and master.

--
Regards, Kirill Yukhin

Re: [Tarantool-patches] [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco

[Alexander Turenko]

LGTM.

On Wed, Apr 15, 2020 at 04:32:39PM +0300, Alexander V. Tikhonov wrote:
> [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco

Nit: Strictly speaking, it is not solely re GitLab CI, but also removes
the job from Travis-CI. As I see, we use 'travis-ci/gitlab-ci' prefix
before two times:

$ git log --oneline | grep travis-ci/gitlab-ci:
961e8c5fe travis-ci/gitlab-ci: remove Ubuntu 18.10 Cosmic
c6cd2e627 travis-ci/gitlab-ci: add ubuntu 19.10
>
> Removed Ubuntu 19.04 Disco from testing which is EOL.

Nit: ...Disco, which is EOL, from testing -- this is better :)

> 
> Close #4896
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4896