From: Alexander Turenko <alexander.turenko@tarantool.org> To: "Alexander V. Tikhonov" <avtikhon@tarantool.org> Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco Date: Thu, 16 Apr 2020 03:46:01 +0300 [thread overview] Message-ID: <20200416004601.yll6nd6k5iiiqgcb@tkn_work_nb> (raw) In-Reply-To: <444a8a7266df491e922ab2a670852a16d6586569.1586957521.git.avtikhon@tarantool.org> LGTM. On Wed, Apr 15, 2020 at 04:32:39PM +0300, Alexander V. Tikhonov wrote: > [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco Nit: Strictly speaking, it is not solely re GitLab CI, but also removes the job from Travis-CI. As I see, we use 'travis-ci/gitlab-ci' prefix before two times: $ git log --oneline | grep travis-ci/gitlab-ci: 961e8c5fe travis-ci/gitlab-ci: remove Ubuntu 18.10 Cosmic c6cd2e627 travis-ci/gitlab-ci: add ubuntu 19.10 > > Removed Ubuntu 19.04 Disco from testing which is EOL. Nit: ...Disco, which is EOL, from testing -- this is better :) > > Close #4896 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci > Issue: https://github.com/tarantool/tarantool/issues/4896
prev parent reply other threads:[~2020-04-16 0:46 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-15 13:32 Alexander V. Tikhonov 2020-04-15 14:53 ` Oleg Piskunov 2020-04-15 15:01 ` Sergey Bronnikov 2020-04-15 15:05 ` Kirill Yukhin 2020-04-16 0:46 ` Alexander Turenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200416004601.yll6nd6k5iiiqgcb@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=o.piskunov@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox