Re: [Tarantool-patches] [PATCH 12/12] popen: allow to close parent's end of std* fds

[Alexander Turenko <alexander.turenko@tarantool.org>]

On Wed, Apr 15, 2020 at 10:43:27AM +0300, Cyrill Gorcunov wrote:
> On Wed, Apr 15, 2020 at 07:21:12AM +0300, Alexander Turenko wrote:
> > 
> > The diff at bottom of the email.
> 
> Ack

Changed after last wording fixes in 'refine popen_{read,write}_timeout
errors' (incremental diff):

diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c
index 638826fb9..3a12a439b 100644
--- a/src/lib/core/popen.c
+++ b/src/lib/core/popen.c
@@ -492,7 +492,7 @@ popen_read_timeout(struct popen_handle *handle, void *buf,
  * Possible errors:
  *
  * - IllegalParams: a parameter check fails:
- *   - flags: neither stdin, stdout nor stderr is choosen.
+ *   - flags: neither stdin, stdout nor stderr is set.
  *   - handle: handle does not support the requested IO operation
  *             (one of fds is not piped).
  */
@@ -509,7 +509,7 @@ popen_shutdown(struct popen_handle *handle, unsigned int flags)
 	/* At least one ..._FD_STDx flag should be set. */
 	if (flags == 0) {
 		diag_set(IllegalParams,
-			 "popen: neither stdin, stdout nor stderr is choosen");
+			 "popen: neither stdin, stdout nor stderr is set");
 		return -1;
 	}