From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>,
Serge Petrenko <sergepetrenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] vclock: rename vclock_reset to vclock_set
Date: Wed, 15 Apr 2020 19:21:05 +0300 [thread overview]
Message-ID: <20200415162105.GO3072@uranus> (raw)
In-Reply-To: <20200415160902.GA21441@atlas>
On Wed, Apr 15, 2020 at 07:09:02PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [20/04/15 17:16]:
> > The `reset` keyword is too overloaded, its traditional
> > context is to setup some value either to zero or to default.
> >
> > That is not what we're doing in this helper: we rather set up
> > a new value to the replica_id in the map, keeping consistency
> > of the sum.
>
> > Thus lets name it as it should -- vclock_set.
>
> Well, one could argue that it's impossible to set a vclock
> component without violating consistency - vclock should never go
> back.
>
> reset() indicates that it can unwind the clock.
Didn't you just named it in correct way -- vlock_unwind() ;-)
Anyway, we've been talking about this name in tchat and
I gave up. Drop the patch please.
next prev parent reply other threads:[~2020-04-15 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 14:13 Cyrill Gorcunov
2020-04-15 16:09 ` Konstantin Osipov
2020-04-15 16:21 ` Cyrill Gorcunov [this message]
2020-04-15 16:32 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415162105.GO3072@uranus \
--to=gorcunov@gmail.com \
--cc=kostja.osipov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vclock: rename vclock_reset to vclock_set' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox