* [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco
@ 2020-04-15 6:07 Alexander V. Tikhonov
2020-04-15 8:25 ` Sergey Bronnikov
2020-04-15 13:24 ` Oleg Piskunov
0 siblings, 2 replies; 6+ messages in thread
From: Alexander V. Tikhonov @ 2020-04-15 6:07 UTC (permalink / raw)
To: Oleg Piskunov, Sergey Bronnikov; +Cc: tarantool-patches
Removed Ubuntu 19.04 Disco from testing which is EOL.
Close #4896
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
Issue: https://github.com/tarantool/tarantool/issues/4896
.gitlab-ci.yml | 14 ++++----------
.travis.yml | 3 ---
2 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index cd710027f..9c996fd7b 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -323,12 +323,6 @@ ubuntu_18_04:
OS: 'ubuntu'
DIST: 'bionic'
-ubuntu_19_04:
- <<: *pack_definition
- variables:
- OS: 'ubuntu'
- DIST: 'disco'
-
ubuntu_19_10:
<<: *pack_definition
variables:
@@ -415,17 +409,17 @@ ubuntu_18_04_deploy:
OS: 'ubuntu'
DIST: 'bionic'
-ubuntu_19_04_deploy:
+ubuntu_19_10_deploy:
<<: *deploy_definition
variables:
OS: 'ubuntu'
- DIST: 'disco'
+ DIST: 'eoan'
-ubuntu_19_10_deploy:
+ubuntu_20_04_deploy:
<<: *deploy_definition
variables:
OS: 'ubuntu'
- DIST: 'eoan'
+ DIST: 'focal'
debian_8_deploy:
<<: *deploy_definition
diff --git a/.travis.yml b/.travis.yml
index c63ab3ebd..41540fb79 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -67,9 +67,6 @@ jobs:
- name: "Ubuntu Bionic (18.04) build + deploy DEB"
env: OS=ubuntu DIST=bionic
if: branch = "master"
- - name: "Ubuntu Disco (19.04) build + deploy DEB"
- env: OS=ubuntu DIST=disco
- if: branch = "master"
- name: "Ubuntu Eoan (19.10) build + deploy DEB"
env: OS=ubuntu DIST=eoan
if: branch = "master"
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco
2020-04-15 6:07 [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco Alexander V. Tikhonov
@ 2020-04-15 8:25 ` Sergey Bronnikov
2020-04-15 9:05 ` Alexander Tikhonov
2020-04-15 13:24 ` Oleg Piskunov
1 sibling, 1 reply; 6+ messages in thread
From: Sergey Bronnikov @ 2020-04-15 8:25 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: Oleg Piskunov, tarantool-patches
Hi,
see comments inline
On 09:07 Wed 15 Apr , Alexander V. Tikhonov wrote:
> Removed Ubuntu 19.04 Disco from testing which is EOL.
>
> Close #4896
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4896
>
> .gitlab-ci.yml | 14 ++++----------
> .travis.yml | 3 ---
> 2 files changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index cd710027f..9c996fd7b 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -323,12 +323,6 @@ ubuntu_18_04:
> OS: 'ubuntu'
> DIST: 'bionic'
>
> -ubuntu_19_04:
> - <<: *pack_definition
> - variables:
> - OS: 'ubuntu'
> - DIST: 'disco'
> -
> ubuntu_19_10:
> <<: *pack_definition
> variables:
> @@ -415,17 +409,17 @@ ubuntu_18_04_deploy:
> OS: 'ubuntu'
> DIST: 'bionic'
>
> -ubuntu_19_04_deploy:
> +ubuntu_19_10_deploy:
> <<: *deploy_definition
> variables:
> OS: 'ubuntu'
> - DIST: 'disco'
> + DIST: 'eoan'
I don't know our policy regarding OS support, but do we want to support
non-LTS releases? 19.10 is non-LTS.
> -ubuntu_19_10_deploy:
> +ubuntu_20_04_deploy:
> <<: *deploy_definition
> variables:
> OS: 'ubuntu'
> - DIST: 'eoan'
> + DIST: 'focal'
>
> debian_8_deploy:
> <<: *deploy_definition
> diff --git a/.travis.yml b/.travis.yml
> index c63ab3ebd..41540fb79 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -67,9 +67,6 @@ jobs:
> - name: "Ubuntu Bionic (18.04) build + deploy DEB"
> env: OS=ubuntu DIST=bionic
> if: branch = "master"
> - - name: "Ubuntu Disco (19.04) build + deploy DEB"
> - env: OS=ubuntu DIST=disco
> - if: branch = "master"
> - name: "Ubuntu Eoan (19.10) build + deploy DEB"
> env: OS=ubuntu DIST=eoan
> if: branch = "master"
> --
> 2.17.1
>
--
sergeyb@
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco
2020-04-15 8:25 ` Sergey Bronnikov
@ 2020-04-15 9:05 ` Alexander Tikhonov
2020-04-15 10:47 ` Sergey Bronnikov
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Tikhonov @ 2020-04-15 9:05 UTC (permalink / raw)
To: Sergey Bronnikov; +Cc: Oleg Piskunov, tarantool-patches
[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]
Hi Sergey, thanks for the review.
e use to test all currently living releases, as we decided before. But anyway we may discuss it and remove short living release versions.
>Среда, 15 апреля 2020, 11:25 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
>
>Hi,
>
>see comments inline
>
>On 09:07 Wed 15 Apr , Alexander V. Tikhonov wrote:
>> Removed Ubuntu 19.04 Disco from testing which is EOL.
>>
>> Close #4896
>> ---
>>
>> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
>> Issue: https://github.com/tarantool/tarantool/issues/4896
>>
>> .gitlab-ci.yml | 14 ++++----------
>> .travis.yml | 3 ---
>> 2 files changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index cd710027f..9c996fd7b 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -323,12 +323,6 @@ ubuntu_18_04:
>> OS: 'ubuntu'
>> DIST: 'bionic'
>>
>> -ubuntu_19_04:
>> - <<: *pack_definition
>> - variables:
>> - OS: 'ubuntu'
>> - DIST: 'disco'
>> -
>> ubuntu_19_10:
>> <<: *pack_definition
>> variables:
>> @@ -415,17 +409,17 @@ ubuntu_18_04_deploy:
>> OS: 'ubuntu'
>> DIST: 'bionic'
>>
>> -ubuntu_19_04_deploy:
>> +ubuntu_19_10_deploy:
>> <<: *deploy_definition
>> variables:
>> OS: 'ubuntu'
>> - DIST: 'disco'
>> + DIST: 'eoan'
>
>I don't know our policy regarding OS support, but do we want to support
>non-LTS releases? 19.10 is non-LTS.
>
>> -ubuntu_19_10_deploy:
>> +ubuntu_20_04_deploy:
>> <<: *deploy_definition
>> variables:
>> OS: 'ubuntu'
>> - DIST: 'eoan'
>> + DIST: 'focal'
>>
>> debian_8_deploy:
>> <<: *deploy_definition
>> diff --git a/.travis.yml b/.travis.yml
>> index c63ab3ebd..41540fb79 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -67,9 +67,6 @@ jobs:
>> - name: "Ubuntu Bionic (18.04) build + deploy DEB"
>> env: OS=ubuntu DIST=bionic
>> if: branch = "master"
>> - - name: "Ubuntu Disco (19.04) build + deploy DEB"
>> - env: OS=ubuntu DIST=disco
>> - if: branch = "master"
>> - name: "Ubuntu Eoan (19.10) build + deploy DEB"
>> env: OS=ubuntu DIST=eoan
>> if: branch = "master"
>> --
>> 2.17.1
>>
>
>--
>sergeyb@
--
Alexander Tikhonov
[-- Attachment #2: Type: text/html, Size: 3177 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco
2020-04-15 9:05 ` Alexander Tikhonov
@ 2020-04-15 10:47 ` Sergey Bronnikov
0 siblings, 0 replies; 6+ messages in thread
From: Sergey Bronnikov @ 2020-04-15 10:47 UTC (permalink / raw)
To: Alexander Tikhonov; +Cc: Oleg Piskunov, tarantool-patches
LGTM
On 12:05 Wed 15 Apr , Alexander Tikhonov wrote:
>
>
> Hi Sergey, thanks for the review.
> e use to test all currently living releases, as we decided before. But
> anyway we may discuss it and remove short living release versions.
>
> >Среда, 15 апреля 2020, 11:25 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
> >
> >Hi,
> >
> >see comments inline
> >
> >On 09:07 Wed 15 Apr , Alexander V. Tikhonov wrote:
> >> Removed Ubuntu 19.04 Disco from testing which is EOL.
> >>
> >> Close #4896
> >> ---
> >>
> >> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
> >> Issue: https://github.com/tarantool/tarantool/issues/4896
> >>
> >> .gitlab-ci.yml | 14 ++++----------
> >> .travis.yml | 3 ---
> >> 2 files changed, 4 insertions(+), 13 deletions(-)
> >>
> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> >> index cd710027f..9c996fd7b 100644
> >> --- a/.gitlab-ci.yml
> >> +++ b/.gitlab-ci.yml
> >> @@ -323,12 +323,6 @@ ubuntu_18_04:
> >> OS: 'ubuntu'
> >> DIST: 'bionic'
> >>
> >> -ubuntu_19_04:
> >> - <<: *pack_definition
> >> - variables:
> >> - OS: 'ubuntu'
> >> - DIST: 'disco'
> >> -
> >> ubuntu_19_10:
> >> <<: *pack_definition
> >> variables:
> >> @@ -415,17 +409,17 @@ ubuntu_18_04_deploy:
> >> OS: 'ubuntu'
> >> DIST: 'bionic'
> >>
> >> -ubuntu_19_04_deploy:
> >> +ubuntu_19_10_deploy:
> >> <<: *deploy_definition
> >> variables:
> >> OS: 'ubuntu'
> >> - DIST: 'disco'
> >> + DIST: 'eoan'
> >
> >I don't know our policy regarding OS support, but do we want to support
> >non-LTS releases? 19.10 is non-LTS.
> >
> >> -ubuntu_19_10_deploy:
> >> +ubuntu_20_04_deploy:
> >> <<: *deploy_definition
> >> variables:
> >> OS: 'ubuntu'
> >> - DIST: 'eoan'
> >> + DIST: 'focal'
> >>
> >> debian_8_deploy:
> >> <<: *deploy_definition
> >> diff --git a/.travis.yml b/.travis.yml
> >> index c63ab3ebd..41540fb79 100644
> >> --- a/.travis.yml
> >> +++ b/.travis.yml
> >> @@ -67,9 +67,6 @@ jobs:
> >> - name: "Ubuntu Bionic (18.04) build + deploy DEB"
> >> env: OS=ubuntu DIST=bionic
> >> if: branch = "master"
> >> - - name: "Ubuntu Disco (19.04) build + deploy DEB"
> >> - env: OS=ubuntu DIST=disco
> >> - if: branch = "master"
> >> - name: "Ubuntu Eoan (19.10) build + deploy DEB"
> >> env: OS=ubuntu DIST=eoan
> >> if: branch = "master"
> >> --
> >> 2.17.1
> >>
> >
> >--
> >sergeyb@
>
>
> --
> Alexander Tikhonov
>
--
sergeyb@
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco
2020-04-15 6:07 [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco Alexander V. Tikhonov
2020-04-15 8:25 ` Sergey Bronnikov
@ 2020-04-15 13:24 ` Oleg Piskunov
2020-04-15 13:34 ` Alexander Tikhonov
1 sibling, 1 reply; 6+ messages in thread
From: Oleg Piskunov @ 2020-04-15 13:24 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: tarantool-patches
[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]
Hi,
Sasha, thanks for the patch.
As I can see you are not only remove ubuntu_19_04 and ubuntu_19_04_deploy, but
also adding ubuntu_20_04_deploy. Which is not related to commit message and issue.
>Среда, 15 апреля 2020, 9:07 +03:00 от Alexander V. Tikhonov <avtikhon@tarantool.org>:
>
>Removed Ubuntu 19.04 Disco from testing which is EOL.
>
>Close #4896
>---
>
>Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
>Issue: https://github.com/tarantool/tarantool/issues/4896
>
> .gitlab-ci.yml | 14 ++++----------
> .travis.yml | 3 ---
> 2 files changed, 4 insertions(+), 13 deletions(-)
>
>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>index cd710027f..9c996fd7b 100644
>--- a/.gitlab-ci.yml
>+++ b/.gitlab-ci.yml
>@@ -323,12 +323,6 @@ ubuntu_18_04:
> OS: 'ubuntu'
> DIST: 'bionic'
>
>-ubuntu_19_04:
>- <<: *pack_definition
>- variables:
>- OS: 'ubuntu'
>- DIST: 'disco'
>-
> ubuntu_19_10:
> <<: *pack_definition
> variables:
>@@ -415,17 +409,17 @@ ubuntu_18_04_deploy:
> OS: 'ubuntu'
> DIST: 'bionic'
>
>-ubuntu_19_04_deploy:
>+ubuntu_19_10_deploy:
> <<: *deploy_definition
> variables:
> OS: 'ubuntu'
>- DIST: 'disco'
>+ DIST: 'eoan'
>
>-ubuntu_19_10_deploy:
>+ubuntu_20_04_deploy:
> <<: *deploy_definition
> variables:
> OS: 'ubuntu'
>- DIST: 'eoan'
>+ DIST: 'focal'
>
> debian_8_deploy:
> <<: *deploy_definition
>diff --git a/.travis.yml b/.travis.yml
>index c63ab3ebd..41540fb79 100644
>--- a/.travis.yml
>+++ b/.travis.yml
>@@ -67,9 +67,6 @@ jobs:
> - name: "Ubuntu Bionic (18.04) build + deploy DEB"
> env: OS=ubuntu DIST=bionic
> if: branch = "master"
>- - name: "Ubuntu Disco (19.04) build + deploy DEB"
>- env: OS=ubuntu DIST=disco
>- if: branch = "master"
> - name: "Ubuntu Eoan (19.10) build + deploy DEB"
> env: OS=ubuntu DIST=eoan
> if: branch = "master"
>--
>2.17.1
>
--
Oleg Piskunov
[-- Attachment #2: Type: text/html, Size: 3400 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco
2020-04-15 13:24 ` Oleg Piskunov
@ 2020-04-15 13:34 ` Alexander Tikhonov
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Tikhonov @ 2020-04-15 13:34 UTC (permalink / raw)
To: Oleg Piskunov; +Cc: tarantool-patches
[-- Attachment #1: Type: text/plain, Size: 2436 bytes --]
Hi Oleg, thanks for the review, mistakenly missed to remove the middle changes for the future release — corrected and patch resent.
>Среда, 15 апреля 2020, 16:24 +03:00 от Oleg Piskunov <o.piskunov@tarantool.org>:
>
>Hi,
>
>Sasha, thanks for the patch.
>
>As I can see you are not only remove ubuntu_19_04 and ubuntu_19_04_deploy, but
>also adding ubuntu_20_04_deploy. Which is not related to commit message and issue.
>
>>Среда, 15 апреля 2020, 9:07 +03:00 от Alexander V. Tikhonov < avtikhon@tarantool.org >:
>>
>>Removed Ubuntu 19.04 Disco from testing which is EOL.
>>
>>Close #4896
>>---
>>
>>Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
>>Issue: https://github.com/tarantool/tarantool/issues/4896
>>
>> .gitlab-ci.yml | 14 ++++----------
>> .travis.yml | 3 ---
>> 2 files changed, 4 insertions(+), 13 deletions(-)
>>
>>diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>index cd710027f..9c996fd7b 100644
>>--- a/.gitlab-ci.yml
>>+++ b/.gitlab-ci.yml
>>@@ -323,12 +323,6 @@ ubuntu_18_04:
>> OS: 'ubuntu'
>> DIST: 'bionic'
>>
>>-ubuntu_19_04:
>>- <<: *pack_definition
>>- variables:
>>- OS: 'ubuntu'
>>- DIST: 'disco'
>>-
>> ubuntu_19_10:
>> <<: *pack_definition
>> variables:
>>@@ -415,17 +409,17 @@ ubuntu_18_04_deploy:
>> OS: 'ubuntu'
>> DIST: 'bionic'
>>
>>-ubuntu_19_04_deploy:
>>+ubuntu_19_10_deploy:
>> <<: *deploy_definition
>> variables:
>> OS: 'ubuntu'
>>- DIST: 'disco'
>>+ DIST: 'eoan'
>>
>>-ubuntu_19_10_deploy:
>>+ubuntu_20_04_deploy:
>> <<: *deploy_definition
>> variables:
>> OS: 'ubuntu'
>>- DIST: 'eoan'
>>+ DIST: 'focal'
>>
>> debian_8_deploy:
>> <<: *deploy_definition
>>diff --git a/.travis.yml b/.travis.yml
>>index c63ab3ebd..41540fb79 100644
>>--- a/.travis.yml
>>+++ b/.travis.yml
>>@@ -67,9 +67,6 @@ jobs:
>> - name: "Ubuntu Bionic (18.04) build + deploy DEB"
>> env: OS=ubuntu DIST=bionic
>> if: branch = "master"
>>- - name: "Ubuntu Disco (19.04) build + deploy DEB"
>>- env: OS=ubuntu DIST=disco
>>- if: branch = "master"
>> - name: "Ubuntu Eoan (19.10) build + deploy DEB"
>> env: OS=ubuntu DIST=eoan
>> if: branch = "master"
>>--
>>2.17.1
>>
>
>
>--
>Oleg Piskunov
>
--
Alexander Tikhonov
[-- Attachment #2: Type: text/html, Size: 4574 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-15 13:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 6:07 [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04 Disco Alexander V. Tikhonov
2020-04-15 8:25 ` Sergey Bronnikov
2020-04-15 9:05 ` Alexander Tikhonov
2020-04-15 10:47 ` Sergey Bronnikov
2020-04-15 13:24 ` Oleg Piskunov
2020-04-15 13:34 ` Alexander Tikhonov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox