From: Sergey Bronnikov <sergeyb@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 2/2] gitlab-ci: set static docker build release testing
Date: Tue, 14 Apr 2020 11:28:18 +0300 [thread overview]
Message-ID: <20200414082818.GE51517@pony.bronevichok.ru> (raw)
In-Reply-To: <b09f44b856e91f1006bd5b3e226a7be0b65b7859.1586263386.git.avtikhon@tarantool.org>
Thanks for the patch!
LGTM
On 17:03 Tue 07 Apr , Alexander V. Tikhonov wrote:
> Returned the static build based on Dockerfile to gitlab-ci release branches
> testing after the issues with missed openssl version fixed at PR #4831.
>
> Follow up #4831
> ---
> .gitlab-ci.yml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index cd710027f..f0d5d9b7c 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -454,6 +454,8 @@ static_build:
>
> static_docker_build:
> <<: *release_only_definition
> - <<: *pack_test_definition
> + stage: test
> + tags:
> + - deploy_test
> script:
> - ${GITLAB_MAKE} test_static_docker_build
> --
> 2.17.1
>
--
sergeyb@
next prev parent reply other threads:[~2020-04-14 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 14:03 [Tarantool-patches] [PATCH v1 0/2] set to gitlab-ci static build with Dockerfile Alexander V. Tikhonov
2020-04-07 14:03 ` [Tarantool-patches] [PATCH v1 1/2] build: disable cache for static build Dockerfile Alexander V. Tikhonov
2020-04-14 8:28 ` Sergey Bronnikov
2020-04-15 8:42 ` Oleg Piskunov
2020-04-07 14:03 ` [Tarantool-patches] [PATCH v1 2/2] gitlab-ci: set static docker build release testing Alexander V. Tikhonov
2020-04-14 8:28 ` Sergey Bronnikov [this message]
2020-04-15 8:44 ` Oleg Piskunov
2020-04-15 12:48 ` [Tarantool-patches] [PATCH v1 0/2] set to gitlab-ci static build with Dockerfile Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414082818.GE51517@pony.bronevichok.ru \
--to=sergeyb@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 2/2] gitlab-ci: set static docker build release testing' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox