Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/2] build: disable cache for static build Dockerfile
Date: Tue, 14 Apr 2020 11:28:02 +0300	[thread overview]
Message-ID: <20200414082802.GD51517@pony.bronevichok.ru> (raw)
In-Reply-To: <1207821e4fc18312a9916d81a55a8eacd75a67b3.1586263386.git.avtikhon@tarantool.org>

Thanks for the patch!

LGTM

On 17:03 Tue 07 Apr , Alexander V. Tikhonov wrote:
> Found that static build based on Dockerfile used external link
> and missed that it was removed, like it was in #4830. To avoid
> of the same issues the cache for building the Dockerfile was
> disabled with '--no-cache' option at docker build command.
> 
> Follow up #4830
> ---
>  .travis.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.mk b/.travis.mk
> index f709a18b6..54a4d5d91 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -143,7 +143,7 @@ test_static_build: deps_debian_static
>  	CMAKE_EXTRA_PARAMS=-DBUILD_STATIC=ON make -f .travis.mk test_debian_no_deps
>  
>  test_static_docker_build:
> -	docker build --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
> +	docker build --no-cache --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
>  
>  #######
>  # OSX #
> -- 
> 2.17.1
> 

-- 
sergeyb@

  reply	other threads:[~2020-04-14  8:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 14:03 [Tarantool-patches] [PATCH v1 0/2] set to gitlab-ci static build with Dockerfile Alexander V. Tikhonov
2020-04-07 14:03 ` [Tarantool-patches] [PATCH v1 1/2] build: disable cache for static build Dockerfile Alexander V. Tikhonov
2020-04-14  8:28   ` Sergey Bronnikov [this message]
2020-04-15  8:42     ` Oleg Piskunov
2020-04-07 14:03 ` [Tarantool-patches] [PATCH v1 2/2] gitlab-ci: set static docker build release testing Alexander V. Tikhonov
2020-04-14  8:28   ` Sergey Bronnikov
2020-04-15  8:44     ` Oleg Piskunov
2020-04-15 12:48 ` [Tarantool-patches] [PATCH v1 0/2] set to gitlab-ci static build with Dockerfile Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414082802.GD51517@pony.bronevichok.ru \
    --to=sergeyb@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 1/2] build: disable cache for static build Dockerfile' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox