From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: o.piskunov@tarantool.org, tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] Fix flaky test engine/ddl
Date: Mon, 13 Apr 2020 16:06:12 +0300 [thread overview]
Message-ID: <20200413130612.GA27992@pony.bronevichok.ru> (raw)
In-Reply-To: <D5D94536-3340-4359-8B77-2930A912A4A4@tarantool.org>
Hi!
Sergey, thanks for review.
On 15:55 Sat 11 Apr , Serge Petrenko wrote:
> Hi! Thanks for the patch!
>
> I think the check can’t fail after `box.snapshot()` even without wait_cond().
> You’ve already waited for the index to build right before `box.snapshot()`.
> It’ s better to leave the last 2 checks without wait_cond to emphasize that
> nothing could happen during `box.snapshot()`.
You are wrong. Test is failed when wait_cond() below 'box.snapshot()' removed.
S.
next prev parent reply other threads:[~2020-04-13 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 13:27 Sergey Bronnikov
2020-04-11 12:55 ` Serge Petrenko
2020-04-13 13:06 ` Sergey Bronnikov [this message]
2020-04-13 8:45 ` Oleg Piskunov
2020-04-15 11:14 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413130612.GA27992@pony.bronevichok.ru \
--to=sergeyb@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Fix flaky test engine/ddl' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox