From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] trigger: add trigger_is_set() method
Date: Mon, 13 Apr 2020 13:00:21 +0300 [thread overview]
Message-ID: <20200413100021.GW3072@uranus> (raw)
In-Reply-To: <7EA6DA75-7106-4E6B-9AC7-59B82B718717@tarantool.org>
On Mon, Apr 13, 2020 at 12:53:45PM +0300, Serge Petrenko wrote:
> >
> > so that trigger_clear won't fail without if statement?
>
> This is doing the same as trigger_create(&&on_close_log);
Yes, except it eliminates redundant trigger_create call :)
> Let’s just omit the if statement then together with the patch
> adding trigger_is_set()?
Yeah, sounds good, lets do it.
next prev parent reply other threads:[~2020-04-13 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 12:33 [Tarantool-patches] [PATCH 0/2] fix replication/anon test segfaut Serge Petrenko
2020-04-11 12:33 ` [Tarantool-patches] [PATCH 1/2] trigger: add trigger_is_set() method Serge Petrenko
2020-04-11 16:33 ` Cyrill Gorcunov
2020-04-13 9:53 ` Serge Petrenko
2020-04-13 10:00 ` Cyrill Gorcunov [this message]
2020-04-11 12:33 ` [Tarantool-patches] [PATCH 2/2] relay: fix segfault on replica transition from anonymous Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413100021.GW3072@uranus \
--to=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] trigger: add trigger_is_set() method' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox