From: Igor Munkin <imun@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] box: export box_session_push to the public C API
Date: Sat, 11 Apr 2020 21:11:28 +0300 [thread overview]
Message-ID: <20200411181128.GI5713@tarantool.org> (raw)
In-Reply-To: <66c72a67-ccbc-c2b3-ce84-df27a32d69ab@tarantool.org>
Vlad,
On 11.04.20, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
>
<snipped>
>
> > The result value is not checked, but <port_msgpack_set_plain> returns -1
> > when OOM occurs.
>
> No need to check result. port_mspack_set_plain() not only returns -1, it
> also keeps port->plain NULL. If it is NULL, it is an error.
>
> port_mspack_dump_plain() returns port->plain. Therefore if there was an
> error, it will return NULL with a correctly installed diag.
OK, thanks, got it. It might be useful to drop a couple words regarding
it. Feel free to ignore.
--
Best regards,
IM
next prev parent reply other threads:[~2020-04-11 18:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 23:20 Vladislav Shpilevoy
2020-04-08 15:33 ` Igor Munkin
2020-04-08 20:35 ` Vladislav Shpilevoy
2020-04-11 9:38 ` Igor Munkin
2020-04-11 18:11 ` Vladislav Shpilevoy
2020-04-11 18:11 ` Igor Munkin [this message]
2020-04-12 14:15 ` Vladislav Shpilevoy
2020-04-14 7:54 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200411181128.GI5713@tarantool.org \
--to=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/1] box: export box_session_push to the public C API' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox