From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] popen: fix 'may be clobbered' compiler warning
Date: Sat, 11 Apr 2020 12:38:58 +0300 [thread overview]
Message-ID: <20200411093858.nwsnbhjjcqi4qqri@tkn_work_nb> (raw)
In-Reply-To: <20200411073026.GT3072@uranus>
On Sat, Apr 11, 2020 at 10:30:26AM +0300, Cyrill Gorcunov wrote:
> On Sat, Apr 11, 2020 at 01:28:07AM +0300, Alexander Turenko wrote:
> > I guess a compiler assumes that the code inside vfork may use the stack
> > slot that corresponds the variable and so clobber it. The recent commit
> > 07a07b3cc7b85375d20b3fc6ca1e5060304f337b ('popen: decouple logger fd
> > from stderr') adds read from this variable after vfork() in the parent
> > process.
> >
> > The warning is produced on RelWithDebInfo build with LTO enabled on GCC
> > 9.2.0 (locally) and on GCC 8.3.0 (in CI).
> >
> > Part of #4031
> Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
Pushed to master.
WBR, Alexander Turenko.
prev parent reply other threads:[~2020-04-11 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 22:28 Alexander Turenko
2020-04-11 7:30 ` Cyrill Gorcunov
2020-04-11 9:38 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200411093858.nwsnbhjjcqi4qqri@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] popen: fix '\''may be clobbered'\'' compiler warning' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox