From: Alexander Turenko <alexander.turenko@tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com> Cc: tml <tarantool-patches@dev.tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 2/2] popen: add ability to keep child on deletion Date: Fri, 10 Apr 2020 19:45:17 +0300 [thread overview] Message-ID: <20200410164517.sngjouuvyn6txtes@tkn_work_nb> (raw) In-Reply-To: <20200410144021.5704-3-gorcunov@gmail.com> On Fri, Apr 10, 2020 at 05:40:21PM +0300, Cyrill Gorcunov wrote: > Currently popen_delete kills all children process. > Moreover we use popen_delete on tarantool exit. > > Alexander pointed out that keep children running > even if tarantool is exited is still needed. > > Reported-by: Alexander Turenko <alexander.turenko@tarantool.org> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> Acked-by: Alexander Turenko <alexander.turenko@tarantool.org> > @@ -489,8 +489,11 @@ popen_delete(struct popen_handle *handle) > return -1; > } > > - if (popen_send_signal(handle, SIGKILL) && errno != ESRCH) > + if ((handle->flags & POPEN_FLAG_KEEP_CHILD) == 0) { > + if (popen_send_signal(handle, SIGKILL) && > + errno != ESRCH) > return -1; > + } Please, rebase after the patchset 'Popen Lua API: preliminary patches', which was pushed to master. > + /* > + * Keep child rinning on delete. > + */ Typo: rinning. > + POPEN_FLAG_KEEP_CHILD_BIT = 17, > + POPEN_FLAG_KEEP_CHILD = (1 << POPEN_FLAG_KEEP_CHILD_BIT), > };
prev parent reply other threads:[~2020-04-10 16:45 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-10 14:40 [Tarantool-patches] [PATCH 0/2] popen: provide more flags Cyrill Gorcunov 2020-04-10 14:40 ` [Tarantool-patches] [PATCH 1/2] popen: Allow to kill process group Cyrill Gorcunov 2020-04-10 16:41 ` Alexander Turenko 2020-04-12 1:27 ` Alexander Turenko 2020-04-12 1:40 ` Alexander Turenko 2020-04-10 14:40 ` [Tarantool-patches] [PATCH 2/2] popen: add ability to keep child on deletion Cyrill Gorcunov 2020-04-10 16:45 ` Alexander Turenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200410164517.sngjouuvyn6txtes@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 2/2] popen: add ability to keep child on deletion' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox