From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH 2/2] popen: add ability to keep child on deletion Date: Fri, 10 Apr 2020 17:40:21 +0300 [thread overview] Message-ID: <20200410144021.5704-3-gorcunov@gmail.com> (raw) In-Reply-To: <20200410144021.5704-1-gorcunov@gmail.com> Currently popen_delete kills all children process. Moreover we use popen_delete on tarantool exit. Alexander pointed out that keep children running even if tarantool is exited is still needed. Reported-by: Alexander Turenko <alexander.turenko@tarantool.org> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/lib/core/popen.c | 5 ++++- src/lib/core/popen.h | 6 ++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c index 200b31b21..50b40b3a4 100644 --- a/src/lib/core/popen.c +++ b/src/lib/core/popen.c @@ -489,8 +489,11 @@ popen_delete(struct popen_handle *handle) return -1; } - if (popen_send_signal(handle, SIGKILL) && errno != ESRCH) + if ((handle->flags & POPEN_FLAG_KEEP_CHILD) == 0) { + if (popen_send_signal(handle, SIGKILL) && + errno != ESRCH) return -1; + } for (i = 0; i < lengthof(handle->ios); i++) { if (handle->ios[i].fd != -1) diff --git a/src/lib/core/popen.h b/src/lib/core/popen.h index f9dd0ff45..2e87e11ff 100644 --- a/src/lib/core/popen.h +++ b/src/lib/core/popen.h @@ -102,6 +102,12 @@ enum popen_flag_bits { */ POPEN_FLAG_GROUP_SIGNAL_BIT = 16, POPEN_FLAG_GROUP_SIGNAL = (1 << POPEN_FLAG_GROUP_SIGNAL_BIT), + + /* + * Keep child rinning on delete. + */ + POPEN_FLAG_KEEP_CHILD_BIT = 17, + POPEN_FLAG_KEEP_CHILD = (1 << POPEN_FLAG_KEEP_CHILD_BIT), }; /** -- 2.20.1
next prev parent reply other threads:[~2020-04-10 14:40 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-10 14:40 [Tarantool-patches] [PATCH 0/2] popen: provide more flags Cyrill Gorcunov 2020-04-10 14:40 ` [Tarantool-patches] [PATCH 1/2] popen: Allow to kill process group Cyrill Gorcunov 2020-04-10 16:41 ` Alexander Turenko 2020-04-12 1:27 ` Alexander Turenko 2020-04-12 1:40 ` Alexander Turenko 2020-04-10 14:40 ` Cyrill Gorcunov [this message] 2020-04-10 16:45 ` [Tarantool-patches] [PATCH 2/2] popen: add ability to keep child on deletion Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200410144021.5704-3-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 2/2] popen: add ability to keep child on deletion' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox