From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Subject: [Tarantool-patches] [PATCH 1/2] popen: Allow to kill process group Date: Fri, 10 Apr 2020 17:40:20 +0300 [thread overview] Message-ID: <20200410144021.5704-2-gorcunov@gmail.com> (raw) In-Reply-To: <20200410144021.5704-1-gorcunov@gmail.com> As Alexander pointed out this might be useful for running a pipe of programs inside shell (i.e. popen.shell('foo | bar | baz', 'r')). Reported-by: Alexander Turenko <alexander.turenko@tarantool.org> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/lib/core/popen.c | 26 +++++++++++++++++++++++--- src/lib/core/popen.h | 6 ++++++ 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c index 6b6062215..200b31b21 100644 --- a/src/lib/core/popen.c +++ b/src/lib/core/popen.c @@ -86,6 +86,19 @@ handle_new(struct popen_opts *opts) assert(opts->argv != NULL && opts->nr_argv > 0); + /* + * Killing group of signals allowed for a new + * session only where it makes sense, otherwise + * child gonna inherit group and we will be killing + * ourself. + */ + if (opts->flags & POPEN_FLAG_GROUP_SIGNAL && + (opts->flags & POPEN_FLAG_SETSID) == 0) { + diag_set(IllegalParams, + "popen: group signal without setting sid"); + return NULL; + } + for (i = 0; i < opts->nr_argv; i++) { if (opts->argv[i] == NULL) continue; @@ -443,10 +456,17 @@ popen_send_signal(struct popen_handle *handle, int signo) if (!popen_may_pidop(handle)) return -1; - say_debug("popen: kill %d signo %d", handle->pid, signo); - ret = kill(handle->pid, signo); + say_debug("popen: %s %d signo %d", + handle->flags & POPEN_FLAG_GROUP_SIGNAL ? + "killpg" : "kill", handle->pid, signo); + if (handle->flags & POPEN_FLAG_GROUP_SIGNAL) + ret = killpg(handle->pid, signo); + else + ret = kill(handle->pid, signo); if (ret < 0) { - diag_set(SystemError, "Unable to kill %d signo %d", + diag_set(SystemError, "Unable to %s %d signo %d", + handle->flags & POPEN_FLAG_GROUP_SIGNAL ? + "killpg" : "kill", handle->pid, signo); } return ret; diff --git a/src/lib/core/popen.h b/src/lib/core/popen.h index 9cbfed60c..f9dd0ff45 100644 --- a/src/lib/core/popen.h +++ b/src/lib/core/popen.h @@ -96,6 +96,12 @@ enum popen_flag_bits { */ POPEN_FLAG_RESTORE_SIGNALS_BIT = 15, POPEN_FLAG_RESTORE_SIGNALS = (1 << POPEN_FLAG_RESTORE_SIGNALS_BIT), + + /* + * Send signal to a process group. + */ + POPEN_FLAG_GROUP_SIGNAL_BIT = 16, + POPEN_FLAG_GROUP_SIGNAL = (1 << POPEN_FLAG_GROUP_SIGNAL_BIT), }; /** -- 2.20.1
next prev parent reply other threads:[~2020-04-10 14:40 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-10 14:40 [Tarantool-patches] [PATCH 0/2] popen: provide more flags Cyrill Gorcunov 2020-04-10 14:40 ` Cyrill Gorcunov [this message] 2020-04-10 16:41 ` [Tarantool-patches] [PATCH 1/2] popen: Allow to kill process group Alexander Turenko 2020-04-12 1:27 ` Alexander Turenko 2020-04-12 1:40 ` Alexander Turenko 2020-04-10 14:40 ` [Tarantool-patches] [PATCH 2/2] popen: add ability to keep child on deletion Cyrill Gorcunov 2020-04-10 16:45 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200410144021.5704-2-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/2] popen: Allow to kill process group' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox