Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 0/2] gitlab-ci: add Catalina OSX 10.15
Date: Fri, 10 Apr 2020 17:34:49 +0300	[thread overview]
Message-ID: <20200410143449.GB36000@pony.bronevichok.ru> (raw)
In-Reply-To: <cover.1586421151.git.avtikhon@tarantool.org>

Hi,

Sasha, thanks for the patch. See my comment below.

On 11:40 Thu 09 Apr , Alexander V. Tikhonov wrote:
> gitlab-ci: add Catalina OSX 10.15
>     
> Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
> due to decided to have only 2 last major releases, for now it is
> 10.14 and 10.15 OSX versions. Also changed the commit job for branches
> from 10.14 to 10.15 OSX version.
>     
> Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
> otherwise it doesn't have the path to brew installed packages.

PATH can be adjusted in runtime with 'export' call and by using
user-specific $HOME/.profile and reloading it to current environemnt.
What are the reasons to touch system-wide file?

> Formula tntpython2.rb consist of the packages which download target host
> does not have valid SSL certificate, disabled curl SSL check for it,
> also the same issue resolved for pip packages.
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/osx_15_catalina-full-ci
> 
> Alexander V. Tikhonov (2):
>   build: disable at OSX curl SSL
>   gitlab-ci: add Catalina OSX 10.15
> 
>  .gitlab-ci.yml | 11 ++++++-----
>  .travis.mk     | 15 +++++++++++++--
>  2 files changed, 19 insertions(+), 7 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 
sergeyb@

  parent reply	other threads:[~2020-04-10 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09  8:40 Alexander V. Tikhonov
2020-04-09  8:40 ` [Tarantool-patches] [PATCH v1 1/2] build: disable at OSX curl SSL Alexander V. Tikhonov
2020-04-13 10:57   ` Oleg Piskunov
2020-04-13 14:48     ` Alexander Tikhonov
2020-04-09  8:40 ` [Tarantool-patches] [PATCH v1 2/2] gitlab-ci: add Catalina OSX 10.15 Alexander V. Tikhonov
2020-04-13 10:50   ` Oleg Piskunov
2020-04-13 11:00     ` Alexander Tikhonov
2020-04-10 14:34 ` Sergey Bronnikov [this message]
2020-04-13 13:49   ` [Tarantool-patches] [PATCH v1 0/2] " Alexander Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200410143449.GB36000@pony.bronevichok.ru \
    --to=sergeyb@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 0/2] gitlab-ci: add Catalina OSX 10.15' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox